Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1365557

[PATCH] regulator: da9053: regulators is an array, so no need to check if NULL

From Colin King <colin.king@canonical.com>
Newsgroups linux.kernel
Subject [PATCH] regulator: da9053: regulators is an array, so no need to check if NULL
Date 2016-03-28 17:50 +0200
Message-ID <rhHAt-C5-13@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


From: Colin Ian King <colin.king@canonical.com>

pdata->regulators is an array, so can never be null, so the
null check on this array is redundant and can be removed.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/regulator/da9052-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/da9052-regulator.c b/drivers/regulator/da9052-regulator.c
index 1050cb7..3a4361a 100644
--- a/drivers/regulator/da9052-regulator.c
+++ b/drivers/regulator/da9052-regulator.c
@@ -420,7 +420,7 @@ static int da9052_regulator_probe(struct platform_device *pdev)
 	config.dev = &pdev->dev;
 	config.driver_data = regulator;
 	config.regmap = da9052->regmap;
-	if (pdata && pdata->regulators) {
+	if (pdata) {
 		config.init_data = pdata->regulators[cell->id];
 	} else {
 #ifdef CONFIG_OF
-- 
2.7.4

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH] regulator: da9053: regulators is an array, so no need to check if NULL Colin King <colin.king@canonical.com> - 2016-03-28 17:50 +0200
  Re: [PATCH] regulator: da9053: regulators is an array, so no need to  check if NULL Mark Brown <broonie@kernel.org> - 2016-03-29 19:10 +0200

csiph-web