Re: [PATCH 0/5] drivers/mtd: make several functions return bool

From	Yaowei Bai <baiyaowei@cmss.chinamobile.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/5] drivers/mtd: make several functions return bool
Date	2016-03-25 10:30 +0100
Message-ID	<rgwe6-82e-3@gated-at.bofh.it> (permalink)
References	<rgpZ0-3o9-1@gated-at.bofh.it> <rgq8G-3rj-3@gated-at.bofh.it> <rgtzA-6c1-9@gated-at.bofh.it> <rguOZ-70i-3@gated-at.bofh.it> <rgvL4-7AD-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Mar 25, 2016 at 09:58:21AM +0100, Boris Brezillon wrote:
> On Fri, 25 Mar 2016 08:57:59 +0100
> Richard Weinberger <richard@nod.at> wrote:
> 
> > Am 25.03.2016 um 07:31 schrieb Yaowei Bai:
> > > On Fri, Mar 25, 2016 at 10:54:51AM +0800, Dongsheng Yang wrote:
> > >> ccing: Brian and Richard
> > >>
> > >> Hi Yao,
> > >>     Is that really necessary? I am not sure how much benefit we can
> > >> achieve from this change.
> > >> Could you explain more?
> > > 
> > > Yes, according to these functions' name, a boolean return value is more
> > > suitable and matchable.
> > > 
> > > Also personally think this change maybe benfit function's return value 
> > > storage in the stack when called on certain architectures.
> > 
> > On which archs? And what exactly is the benefit?
> > I agree that bool might be a better choice for new functions
> > but here you're touching existing and working(!) code.
> > The only outcome is git history pollution that makes git blame
> > less efficient.
> 
> Indeed, you raised a good point. Having useless changes pollute git
> blame output may be problematic. Not sure I want to apply those patches
> anymore :-/.
> 
> Anyway, Yao, I'm sure you can find other usefull things to contribute.

OK, thanks for reviewing.

> 
> -- 
> Boris Brezillon, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] drivers/mtd: make several functions return bool Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2016-03-25 03:50 +0100
  [PATCH 1/5] drivers/mtd: mtd_is_partition can be boolean Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2016-03-25 03:50 +0100
  [PATCH 5/5] drivers/mtd/nand: nand_opcode_8bits can be boolean Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2016-03-25 03:50 +0100
  [PATCH 2/5] drivers/mtd: cfi_interleave_supported can be boolean Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2016-03-25 03:50 +0100
  [PATCH 4/5] drivers/mtd: mtd_nand_has_bch can be boolean Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2016-03-25 03:50 +0100
  [PATCH 3/5] drivers/mtd: map_bankwidth_supported can be boolean Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2016-03-25 03:50 +0100
  Re: [PATCH 0/5] drivers/mtd: make several functions return bool Dongsheng Yang <dongsheng.yang@easystack.cn> - 2016-03-25 04:00 +0100
    Re: [PATCH 0/5] drivers/mtd: make several functions return bool Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2016-03-25 07:40 +0100
      Re: [PATCH 0/5] drivers/mtd: make several functions return bool Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-03-25 09:00 +0100
        Re: [PATCH 0/5] drivers/mtd: make several functions return bool Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2016-03-25 09:50 +0100
      Re: [PATCH 0/5] drivers/mtd: make several functions return bool Richard Weinberger <richard@nod.at> - 2016-03-25 09:00 +0100
        Re: [PATCH 0/5] drivers/mtd: make several functions return bool Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2016-03-25 09:50 +0100
        Re: [PATCH 0/5] drivers/mtd: make several functions return bool Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-03-25 10:00 +0100
          Re: [PATCH 0/5] drivers/mtd: make several functions return bool Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2016-03-25 10:30 +0100

csiph-web