Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1364827

[patch 2/2 v2] drm/exynos: fix a warning message

From Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups linux.kernel
Subject [patch 2/2 v2] drm/exynos: fix a warning message
Date 2016-03-25 21:10 +0100
Message-ID <rgGdr-72X-1@gated-at.bofh.it> (permalink)
References <rgvL4-7AD-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


The "ret = regmap_write()" assignment was missing so this error message
is never printed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: in v1 I just deleted the error message

diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
index 9869d70..ea2ea17 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
@@ -129,7 +129,7 @@ static void mic_set_path(struct exynos_mic *mic, bool enable)
 	} else
 		val &= ~(MIC0_RGB_MUX | MIC0_I80_MUX | MIC0_ON_MUX);
 
-	regmap_write(mic->sysreg, DSD_CFG_MUX, val);
+	ret = regmap_write(mic->sysreg, DSD_CFG_MUX, val);
 	if (ret)
 		DRM_ERROR("mic: Failed to read system register\n");
 }

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [patch 2/2] drm/exynos: mic: remove some dead code Inki Dae <inki.dae@samsung.com> - 2016-03-25 10:00 +0100
  [patch 2/2 v2] drm/exynos: fix a warning message Dan Carpenter <dan.carpenter@oracle.com> - 2016-03-25 21:10 +0100
  Re: [patch 2/2] drm/exynos: mic: remove some dead code Dan Carpenter <dan.carpenter@oracle.com> - 2016-03-25 21:10 +0100

csiph-web