Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1364615

Re: [patch 2/2] drm/exynos: mic: remove some dead code

Show all headers | View raw

Hi Dan,

2016년 03월 17일 19:39에 Dan Carpenter 이(가) 쓴 글:
> We know "ret" is zero and the test makes static checkers complain so
> let's delete this printk.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> index 890c9b1..12db353 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> @@ -130,8 +130,6 @@ static void mic_set_path(struct exynos_mic *mic, bool enable)
>  		val &= ~(MIC0_RGB_MUX | MIC0_I80_MUX | MIC0_ON_MUX);
>  
>  	regmap_write(mic->sysreg, DSD_CFG_MUX, val);
> -	if (ret)
> -		DRM_ERROR("mic: Failed to read system register\n");

I think we missed to keep return value from regmap_write function,
	ret = regmap_write(mic->sysreg, ....);
	if (ret)
		...

Thanks,
Inki Dae

>  }
>  
>  static int mic_sw_reset(struct exynos_mic *mic)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [patch 2/2] drm/exynos: mic: remove some dead code Inki Dae <inki.dae@samsung.com> - 2016-03-25 10:00 +0100
  [patch 2/2 v2] drm/exynos: fix a warning message Dan Carpenter <dan.carpenter@oracle.com> - 2016-03-25 21:10 +0100
  Re: [patch 2/2] drm/exynos: mic: remove some dead code Dan Carpenter <dan.carpenter@oracle.com> - 2016-03-25 21:10 +0100

csiph-web