Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1363094

Re: [PATCH 1/9] sched: add schedule_timeout_idle()

Show all headers | View raw

On Tue, 22 Mar 2016 13:23:45 +0100 Peter Zijlstra <peterz@infradead.org> wrote:

> On Tue, Mar 22, 2016 at 12:00:18PM +0100, Michal Hocko wrote:
> 
> >  extern signed long schedule_timeout_interruptible(signed long timeout);
> >  extern signed long schedule_timeout_killable(signed long timeout);
> >  extern signed long schedule_timeout_uninterruptible(signed long timeout);
> > +extern signed long schedule_timeout_idle(signed long timeout);
> 
> > +/*
> > + * Like schedule_timeout_uninterruptible(), except this task will not contribute
> > + * to load average.
> > + */
> > +signed long __sched schedule_timeout_idle(signed long timeout)
> > +{
> > +	__set_current_state(TASK_IDLE);
> > +	return schedule_timeout(timeout);
> > +}
> > +EXPORT_SYMBOL(schedule_timeout_idle);
> 
> Yes we have 3 such other wrappers, but I've gotta ask: why? They seem
> pretty pointless.

I like the wrappers.  At least, more than having to read the open-coded
version.  The latter is just more stuff to interpret and to check
whereas I can look at "schedule_timeout_idle" and think "yup, I know
what that does".

But whatever.  I'll probably be sending this series up for 4.6 and we can
worry about the schedule_timeout_foo() stuff later.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/9] sched: add schedule_timeout_idle() Michal Hocko <mhocko@kernel.org> - 2016-03-22 12:10 +0100
  Re: [PATCH 1/9] sched: add schedule_timeout_idle() Peter Zijlstra <peterz@infradead.org> - 2016-03-22 13:30 +0100
    Re: [PATCH 1/9] sched: add schedule_timeout_idle() Michal Hocko <mhocko@kernel.org> - 2016-03-22 13:40 +0100
      Re: [PATCH 1/9] sched: add schedule_timeout_idle() Peter Zijlstra <peterz@infradead.org> - 2016-03-22 14:00 +0100
        Re: [PATCH 1/9] sched: add schedule_timeout_idle() Michal Hocko <mhocko@kernel.org> - 2016-03-22 14:10 +0100
          Re: [PATCH 1/9] sched: add schedule_timeout_idle() Peter Zijlstra <peterz@infradead.org> - 2016-03-22 14:30 +0100
            Re: [PATCH 1/9] sched: add schedule_timeout_idle() Johannes Weiner <hannes@cmpxchg.org> - 2016-03-22 19:00 +0100
              Re: [PATCH 1/9] sched: add schedule_timeout_idle() Peter Zijlstra <peterz@infradead.org> - 2016-03-22 22:30 +0100
                Re: [PATCH 1/9] sched: add schedule_timeout_idle() Michal Hocko <mhocko@kernel.org> - 2016-03-23 11:50 +0100
    Re: [PATCH 1/9] sched: add schedule_timeout_idle() Andrew Morton <akpm@linux-foundation.org> - 2016-03-23 00:10 +0100

csiph-web