Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1359735

Re: [PATCH v2 10/11] usb: musb: da8xx: Use devm in probe

Show all headers | View raw

Hello.

On 3/17/2016 5:26 AM, David Lechner wrote:

> Simplify things a bit by using devm functions where possible.
>
> Signed-off-by: David Lechner <david@lechnology.com>
> ---
>
> v2 changes: This is part of a previous patch that was split. No changes from
> previous version.
>
>
>   drivers/usb/musb/da8xx.c | 28 ++++++++--------------------
>   1 file changed, 8 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c
> index b03d3b8..50f07a5 100644
> --- a/drivers/usb/musb/da8xx.c
> +++ b/drivers/usb/musb/da8xx.c
> @@ -489,32 +489,27 @@ static int da8xx_probe(struct platform_device *pdev)
>   	struct platform_device		*musb;
>   	struct da8xx_glue		*glue;
>   	struct platform_device_info	pinfo;
> -	struct clk			*clk;

    I wouldn't remove this variable to minimize the patch.

[...]

MBR, Sergei

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 00/11] da8xx USB clocks David Lechner <david@lechnology.com> - 2016-03-17 04:40 +0100
  [PATCH v2 07/11] ARM: davinci: da8xx: Add USB PHY platform declaration David Lechner <david@lechnology.com> - 2016-03-17 04:50 +0100
  [PATCH v2 10/11] usb: musb: da8xx: Use devm in probe David Lechner <david@lechnology.com> - 2016-03-17 04:50 +0100
    Re: [PATCH v2 10/11] usb: musb: da8xx: Use devm in probe Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-17 12:10 +0100
  [PATCH v2 02/11] ARM: davinci: add set_parent callback for mux clocks David Lechner <david@lechnology.com> - 2016-03-17 04:50 +0100
  [PATCH v2 01/11] ARM: davinci: defined missing CFGCHIP2_REFFREQ_* macros for MUSB PHY David Lechner <david@lechnology.com> - 2016-03-17 04:50 +0100
  [PATCH v2 09/11] usb: ohci-da8xx: Remove code that references mach David Lechner <david@lechnology.com> - 2016-03-17 04:50 +0100
    Re: [PATCH v2 09/11] usb: ohci-da8xx: Remove code that references  mach Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-17 14:00 +0100
    Re: [PATCH v2 09/11] usb: ohci-da8xx: Remove code that references  mach Alan Stern <stern@rowland.harvard.edu> - 2016-03-17 19:10 +0100
  [PATCH v2 04/11] ARM: davinci: da8xx: add usb phy clocks David Lechner <david@lechnology.com> - 2016-03-17 04:50 +0100
    Re: [PATCH v2 04/11] ARM: davinci: da8xx: add usb phy clocks Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-17 13:20 +0100
    Re: [PATCH v2 04/11] ARM: davinci: da8xx: add usb phy clocks Sekhar Nori <nsekhar@ti.com> - 2016-03-23 18:00 +0100
      Re: [PATCH v2 04/11] ARM: davinci: da8xx: add usb phy clocks David Lechner <david@lechnology.com> - 2016-03-23 18:50 +0100
        Re: [PATCH v2 04/11] ARM: davinci: da8xx: add usb phy clocks Sekhar Nori <nsekhar@ti.com> - 2016-03-23 19:00 +0100
  [PATCH v2 03/11] ARM: davinci: da850: use clk->set_parent for async3 David Lechner <david@lechnology.com> - 2016-03-17 04:50 +0100
    Re: [PATCH v2 03/11] ARM: davinci: da850: use clk->set_parent for  async3 Sekhar Nori <nsekhar@ti.com> - 2016-03-23 17:00 +0100
      Re: [PATCH v2 03/11] ARM: davinci: da850: use clk->set_parent for  async3 David Lechner <david@lechnology.com> - 2016-03-23 18:30 +0100
        Re: [PATCH v2 03/11] ARM: davinci: da850: use clk->set_parent for  async3 Sekhar Nori <nsekhar@ti.com> - 2016-03-23 18:40 +0100
          Re: [PATCH v2 03/11] ARM: davinci: da850: use clk->set_parent for  async3 David Lechner <david@lechnology.com> - 2016-03-23 19:40 +0100
            Re: [PATCH v2 03/11] ARM: davinci: da850: use clk->set_parent for  async3 Sekhar Nori <nsekhar@ti.com> - 2016-03-24 14:50 +0100
  Re: [PATCH v2 00/11] da8xx USB clocks Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-17 14:40 +0100
    Re: [PATCH v2 00/11] da8xx USB clocks Sekhar Nori <nsekhar@ti.com> - 2016-03-23 18:30 +0100

csiph-web