Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1359557
| From | David Lechner <david@lechnology.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2 10/11] usb: musb: da8xx: Use devm in probe |
| Date | 2016-03-17 04:50 +0100 |
| Message-ID | <rdx6G-1Ps-9@gated-at.bofh.it> (permalink) |
| References | <rdwWZ-1LR-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Simplify things a bit by using devm functions where possible.
Signed-off-by: David Lechner <david@lechnology.com>
---
v2 changes: This is part of a previous patch that was split. No changes from
previous version.
drivers/usb/musb/da8xx.c | 28 ++++++++--------------------
1 file changed, 8 insertions(+), 20 deletions(-)
diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c
index b03d3b8..50f07a5 100644
--- a/drivers/usb/musb/da8xx.c
+++ b/drivers/usb/musb/da8xx.c
@@ -489,32 +489,27 @@ static int da8xx_probe(struct platform_device *pdev)
struct platform_device *musb;
struct da8xx_glue *glue;
struct platform_device_info pinfo;
- struct clk *clk;
+ int ret;
- int ret = -ENOMEM;
-
- glue = kzalloc(sizeof(*glue), GFP_KERNEL);
+ glue = devm_kzalloc(&pdev->dev, sizeof(*glue), GFP_KERNEL);
if (!glue) {
dev_err(&pdev->dev, "failed to allocate glue context\n");
- goto err0;
+ return -ENOMEM;
}
- clk = clk_get(&pdev->dev, "usb20");
- if (IS_ERR(clk)) {
+ glue->clk = devm_clk_get(&pdev->dev, "usb20");
+ if (IS_ERR(glue->clk)) {
dev_err(&pdev->dev, "failed to get clock\n");
- ret = PTR_ERR(clk);
- goto err3;
+ return PTR_ERR(glue->clk);
}
- ret = clk_enable(clk);
+ ret = clk_enable(glue->clk);
if (ret) {
dev_err(&pdev->dev, "failed to enable clock\n");
goto err4;
}
glue->dev = &pdev->dev;
- glue->clk = clk;
-
pdata->platform_ops = &da8xx_ops;
glue->phy = usb_phy_generic_register();
@@ -557,15 +552,10 @@ err6:
usb_phy_generic_unregister(glue->phy);
err5:
- clk_disable(clk);
+ clk_disable(glue->clk);
err4:
- clk_put(clk);
-
-err3:
- kfree(glue);
-err0:
return ret;
}
@@ -576,8 +566,6 @@ static int da8xx_remove(struct platform_device *pdev)
platform_device_unregister(glue->musb);
usb_phy_generic_unregister(glue->phy);
clk_disable(glue->clk);
- clk_put(glue->clk);
- kfree(glue);
return 0;
}
--
1.9.1
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 00/11] da8xx USB clocks David Lechner <david@lechnology.com> - 2016-03-17 04:40 +0100
[PATCH v2 07/11] ARM: davinci: da8xx: Add USB PHY platform declaration David Lechner <david@lechnology.com> - 2016-03-17 04:50 +0100
[PATCH v2 10/11] usb: musb: da8xx: Use devm in probe David Lechner <david@lechnology.com> - 2016-03-17 04:50 +0100
Re: [PATCH v2 10/11] usb: musb: da8xx: Use devm in probe Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-17 12:10 +0100
[PATCH v2 02/11] ARM: davinci: add set_parent callback for mux clocks David Lechner <david@lechnology.com> - 2016-03-17 04:50 +0100
[PATCH v2 01/11] ARM: davinci: defined missing CFGCHIP2_REFFREQ_* macros for MUSB PHY David Lechner <david@lechnology.com> - 2016-03-17 04:50 +0100
[PATCH v2 09/11] usb: ohci-da8xx: Remove code that references mach David Lechner <david@lechnology.com> - 2016-03-17 04:50 +0100
Re: [PATCH v2 09/11] usb: ohci-da8xx: Remove code that references mach Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-17 14:00 +0100
Re: [PATCH v2 09/11] usb: ohci-da8xx: Remove code that references mach Alan Stern <stern@rowland.harvard.edu> - 2016-03-17 19:10 +0100
[PATCH v2 04/11] ARM: davinci: da8xx: add usb phy clocks David Lechner <david@lechnology.com> - 2016-03-17 04:50 +0100
Re: [PATCH v2 04/11] ARM: davinci: da8xx: add usb phy clocks Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-17 13:20 +0100
Re: [PATCH v2 04/11] ARM: davinci: da8xx: add usb phy clocks Sekhar Nori <nsekhar@ti.com> - 2016-03-23 18:00 +0100
Re: [PATCH v2 04/11] ARM: davinci: da8xx: add usb phy clocks David Lechner <david@lechnology.com> - 2016-03-23 18:50 +0100
Re: [PATCH v2 04/11] ARM: davinci: da8xx: add usb phy clocks Sekhar Nori <nsekhar@ti.com> - 2016-03-23 19:00 +0100
[PATCH v2 03/11] ARM: davinci: da850: use clk->set_parent for async3 David Lechner <david@lechnology.com> - 2016-03-17 04:50 +0100
Re: [PATCH v2 03/11] ARM: davinci: da850: use clk->set_parent for async3 Sekhar Nori <nsekhar@ti.com> - 2016-03-23 17:00 +0100
Re: [PATCH v2 03/11] ARM: davinci: da850: use clk->set_parent for async3 David Lechner <david@lechnology.com> - 2016-03-23 18:30 +0100
Re: [PATCH v2 03/11] ARM: davinci: da850: use clk->set_parent for async3 Sekhar Nori <nsekhar@ti.com> - 2016-03-23 18:40 +0100
Re: [PATCH v2 03/11] ARM: davinci: da850: use clk->set_parent for async3 David Lechner <david@lechnology.com> - 2016-03-23 19:40 +0100
Re: [PATCH v2 03/11] ARM: davinci: da850: use clk->set_parent for async3 Sekhar Nori <nsekhar@ti.com> - 2016-03-24 14:50 +0100
Re: [PATCH v2 00/11] da8xx USB clocks Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-17 14:40 +0100
Re: [PATCH v2 00/11] da8xx USB clocks Sekhar Nori <nsekhar@ti.com> - 2016-03-23 18:30 +0100
csiph-web