Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1357017
| From | Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC][PATCH v3 2/5] mm/zsmalloc: remove shrinker compaction callbacks |
| Date | 2016-03-14 08:50 +0100 |
| Message-ID | <rcvqi-KB-19@gated-at.bofh.it> (permalink) |
| References | <r8CJI-8oR-5@gated-at.bofh.it> <r8CJI-8oR-13@gated-at.bofh.it> <rcuky-5w-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On (03/14/16 15:32), Minchan Kim wrote: > On Thu, Mar 03, 2016 at 11:46:00PM +0900, Sergey Senozhatsky wrote: > > Do not register shrinker compaction callbacks anymore, since > > now we shedule class compaction work each time its fragmentation > > value goes above the watermark. > > I suggested to remove shrinker compaction but while I review your > first patch in this thread, I thought we need upper-bound to > compact zspage so background work can bail out for latency easily. > IOW, the work could give up the job. In such case, we might need > fall-back scheme to continue the job. And I think that could be > a shrinker. > > What do you think? wouldn't this unnecessarily complicate the whole thing? we would have a) a compaction that can be triggered by used space b) a compaction from zs_free() that can bail out c) a compaction triggered by the shrinker. all 3 three can run simultaneously. _if_ we can keep every class below its watermark, we can reduce the need of "c)". -ss
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [RFC][PATCH v3 2/5] mm/zsmalloc: remove shrinker compaction callbacks Minchan Kim <minchan@kernel.org> - 2016-03-14 07:40 +0100
Re: [RFC][PATCH v3 2/5] mm/zsmalloc: remove shrinker compaction callbacks Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-03-14 08:50 +0100
Re: [RFC][PATCH v3 2/5] mm/zsmalloc: remove shrinker compaction callbacks Minchan Kim <minchan@kernel.org> - 2016-03-15 02:00 +0100
Re: [RFC][PATCH v3 2/5] mm/zsmalloc: remove shrinker compaction callbacks Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-03-15 02:10 +0100
Re: [RFC][PATCH v3 2/5] mm/zsmalloc: remove shrinker compaction callbacks Minchan Kim <minchan@kernel.org> - 2016-03-15 03:20 +0100
csiph-web