Re: [RFC][PATCH v3 2/5] mm/zsmalloc: remove shrinker compaction callbacks

From	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCH v3 2/5] mm/zsmalloc: remove shrinker compaction callbacks
Date	2016-03-15 02:10 +0100
Message-ID	<rcLEK-3h7-1@gated-at.bofh.it> (permalink)
References	<r8CJI-8oR-5@gated-at.bofh.it> <r8CJI-8oR-13@gated-at.bofh.it> <rcuky-5w-1@gated-at.bofh.it> <rcvqi-KB-19@gated-at.bofh.it> <rcLv4-2Yx-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On (03/15/16 09:52), Minchan Kim wrote:
[..]
> > > I suggested to remove shrinker compaction but while I review your
> > > first patch in this thread, I thought we need upper-bound to
> > > compact zspage so background work can bail out for latency easily.
> > > IOW, the work could give up the job. In such case, we might need
> > > fall-back scheme to continue the job. And I think that could be
> > > a shrinker.
> > > 
> > > What do you think?
> > 
> > wouldn't this unnecessarily complicate the whole thing? we would
> > have
> >  a) a compaction that can be triggered by used space
> 
> Maybe, user space? :)

haha, yes!  sorry, I do quite a lot of typos.

> >  b) a compaction from zs_free() that can bail out
> >  c) a compaction triggered by the shrinker.
> > 
> > all 3 three can run simultaneously.
> 
> Yeb.
> 
> > 
> > 
> > _if_ we can keep every class below its watermark, we can reduce the
> > need of "c)".
> 
> But the problem is timing. We cannot guarantee when background
> compaction triggers while shrinker is interop with VM so we should
> do the job instantly for the system.

we can have pool's compaction-kthread that we will wake_up()
every time we need a compaction, with no dependency on workqueue
or shrinker.

	-ss

Thread

Re: [RFC][PATCH v3 2/5] mm/zsmalloc: remove shrinker compaction  callbacks Minchan Kim <minchan@kernel.org> - 2016-03-14 07:40 +0100
  Re: [RFC][PATCH v3 2/5] mm/zsmalloc: remove shrinker compaction  callbacks Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-03-14 08:50 +0100
    Re: [RFC][PATCH v3 2/5] mm/zsmalloc: remove shrinker compaction  callbacks Minchan Kim <minchan@kernel.org> - 2016-03-15 02:00 +0100
      Re: [RFC][PATCH v3 2/5] mm/zsmalloc: remove shrinker compaction  callbacks Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-03-15 02:10 +0100
        Re: [RFC][PATCH v3 2/5] mm/zsmalloc: remove shrinker compaction  callbacks Minchan Kim <minchan@kernel.org> - 2016-03-15 03:20 +0100

csiph-web