Re: [PATCH] xhci: fix typo in babble endpoint handling comment

From	Felipe Balbi <felipe.balbi@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] xhci: fix typo in babble endpoint handling comment
Date	2016-03-11 08:00 +0100
Message-ID	<rbpdf-2ct-1@gated-at.bofh.it> (permalink)
References	<rbpdf-2ct-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Rajesh Bhagat <rajesh.bhagat@nxp.com> writes:

> [ text/plain ]
> The 0.95 xHCI spec says that non-control endpoints will be halted if a
> babble is detected on a transfer.  The 0.96 xHCI spec says all types of
> endpoints will be halted when a babble is detected.  Some hardware that
> claims to be 0.95 compliant halts the control endpoint anyway.
>
> Reference: http://www.spinics.net/lists/linux-usb/msg21755.html
>
> Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com>

Reviewed-by: Felipe Balbi <balbi@kernel.org>

> ---
>  drivers/usb/host/xhci-ring.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> index 3915657..59841a9 100644
> --- a/drivers/usb/host/xhci-ring.c
> +++ b/drivers/usb/host/xhci-ring.c
> @@ -1768,7 +1768,7 @@ static int xhci_requires_manual_halt_cleanup(struct xhci_hcd *xhci,
>  	if (trb_comp_code == COMP_TX_ERR ||
>  			trb_comp_code == COMP_BABBLE ||
>  			trb_comp_code == COMP_SPLIT_ERR)
> -		/* The 0.96 spec says a babbling control endpoint
> +		/* The 0.95 spec says a babbling control endpoint
>  		 * is not halted. The 0.96 spec says it is.  Some HW
>  		 * claims to be 0.95 compliant, but it halts the control
>  		 * endpoint anyway.  Check if a babble halted the
> -- 
> 2.6.2.198.g614a2ac
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
balbi

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] xhci: fix typo in babble endpoint handling comment Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-03-11 08:00 +0100

csiph-web