[PATCH] kcm: fix variable type

From	Andrzej Hajda <a.hajda@samsung.com>
Newsgroups	linux.kernel
Subject	[PATCH] kcm: fix variable type
Date	2016-03-11 08:00 +0100
Message-ID	<rbpdf-2ct-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Function skb_splice_bits can return negative values, its result should
be assigned to signed variable to allow correct error checking.

The problem has been detected using patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci.

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
 net/kcm/kcmsock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/kcm/kcmsock.c b/net/kcm/kcmsock.c
index 40662d73..0b68ba7 100644
--- a/net/kcm/kcmsock.c
+++ b/net/kcm/kcmsock.c
@@ -1483,7 +1483,7 @@ static ssize_t kcm_splice_read(struct socket *sock, loff_t *ppos,
 	long timeo;
 	struct kcm_rx_msg *rxm;
 	int err = 0;
-	size_t copied;
+	ssize_t copied;
 	struct sk_buff *skb;
 
 	/* Only support splice for SOCKSEQPACKET */
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] kcm: fix variable type Andrzej Hajda <a.hajda@samsung.com> - 2016-03-11 08:00 +0100
  Re: [PATCH] kcm: fix variable type David Miller <davem@davemloft.net> - 2016-03-11 17:50 +0100
    Re: [PATCH] kcm: fix variable type Andrzej Hajda <a.hajda@samsung.com> - 2016-03-14 07:50 +0100

csiph-web