Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1353043

[PATCH 2/2] tracing: fix typoes in code comment and printk in trace_nop.c

Show all headers | View raw

echo nop > /sys/kernel/debug/tracing/options/current_tracer
echo 1 > /sys/kernel/debug/tracing/options/test_nop_accept
echo 0 > /sys/kernel/debug/tracing/options/test_nop_accept
echo 1 > /sys/kernel/debug/tracing/options/test_nop_refuse

Before the fix, the dmesg is a bit ugly since a align issue.

[  191.973081] nop_test_accept flag set to 1: we accept. Now cat trace_options to see the result
[  195.156942] nop_test_refuse flag set to 1: we refuse.Now cat trace_options to see the result

After the fix, the dmesg will show aligned log for nop_test_refuse and nop_test_accept.

[ 2718.032413] nop_test_refuse flag set to 1: we refuse. Now cat trace_options to see the result
[ 2734.253360] nop_test_accept flag set to 1: we accept. Now cat trace_options to see the result

Signed-off-by: Chunyu Hu <chuhu@redhat.com>
---
 kernel/trace/trace_nop.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/trace/trace_nop.c b/kernel/trace/trace_nop.c
index 8bb2071..49f61fe 100644
--- a/kernel/trace/trace_nop.c
+++ b/kernel/trace/trace_nop.c
@@ -56,7 +56,7 @@ static void nop_trace_reset(struct trace_array *tr)
 }
 
 /* It only serves as a signal handler and a callback to
- * accept or refuse tthe setting of a flag.
+ * accept or refuse the setting of a flag.
  * If you don't implement it, then the flag setting will be
  * automatically accepted.
  */
@@ -75,7 +75,7 @@ static int nop_set_flag(struct trace_array *tr, u32 old_flags, u32 bit, int set)
 
 	if (bit == TRACE_NOP_OPT_REFUSE) {
 		printk(KERN_DEBUG "nop_test_refuse flag set to %d: we refuse."
-			"Now cat trace_options to see the result\n",
+			" Now cat trace_options to see the result\n",
 			set);
 		return -EINVAL;
 	}
-- 
1.8.3.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] tracing: make tracer_flags use the right set_flag callback Chunyu Hu <chuhu@redhat.com> - 2016-03-08 14:40 +0100
  [PATCH 2/2] tracing: fix typoes in code comment and printk in trace_nop.c Chunyu Hu <chuhu@redhat.com> - 2016-03-08 14:40 +0100
  Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag  callback kbuild test robot <lkp@intel.com> - 2016-03-08 15:00 +0100
  Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag  callback Steven Rostedt <rostedt@goodmis.org> - 2016-03-08 15:20 +0100
  Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag  callback Steven Rostedt <rostedt@goodmis.org> - 2016-03-08 15:40 +0100
    Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag  callback Chunyu Hu <chuhu@redhat.com> - 2016-03-08 16:30 +0100
      Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag  callback Steven Rostedt <rostedt@goodmis.org> - 2016-03-08 16:40 +0100
        Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag  callback Steven Rostedt <rostedt@goodmis.org> - 2016-03-08 16:40 +0100
      Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag  callback Steven Rostedt <rostedt@goodmis.org> - 2016-03-08 16:40 +0100
  Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag  callback Steven Rostedt <rostedt@goodmis.org> - 2016-03-08 16:00 +0100
    Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag  callback Steven Rostedt <rostedt@goodmis.org> - 2016-03-08 16:20 +0100
      Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag  callback Chunyu Hu <chuhu@redhat.com> - 2016-03-08 17:00 +0100
        Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag  callback Steven Rostedt <rostedt@goodmis.org> - 2016-03-08 17:30 +0100
          Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag  callback Chunyu Hu <chuhu@redhat.com> - 2016-03-09 14:40 +0100
            Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag  callback Steven Rostedt <rostedt@goodmis.org> - 2016-03-09 15:00 +0100

csiph-web