Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1353151
| From | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag callback |
| Date | 2016-03-08 16:40 +0100 |
| Message-ID | <rarTQ-2Ho-13@gated-at.bofh.it> (permalink) |
| References | <raq1I-1uo-19@gated-at.bofh.it> <raqXM-25J-15@gated-at.bofh.it> <rarKa-2CK-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, 8 Mar 2016 10:22:07 -0500 (EST)
Chunyu Hu <chuhu@redhat.com> wrote:
> Thanks for the quick review! This is an mistake, the change below should be after it. From my
> limited knowledge and observation, seems there is no tracer sharing the tracer_flag except the
> dummy_tracer flag. As in the patch that flag is not shared any more, so i also removed these check
> in the previous email.
>
>
> @@ -6390,15 +6400,6 @@ create_trace_option_files(struct trace_array *tr, struct tracer *tracer)
> if (!trace_ok_for_array(tracer, tr))
> return;
>
> - for (i = 0; i < tr->nr_topts; i++) {
> - /*
> - * Check if these flags have already been added.
> - * Some tracers share flags.
> - */
> - if (tr->topts[i].tracer->flags == tracer->flags)
> - return;
> - }
> -
>
The latency tracers share flags (irqsoff, preemptoff and preemptirqsoff)
-- Steve
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/2] tracing: make tracer_flags use the right set_flag callback Chunyu Hu <chuhu@redhat.com> - 2016-03-08 14:40 +0100
[PATCH 2/2] tracing: fix typoes in code comment and printk in trace_nop.c Chunyu Hu <chuhu@redhat.com> - 2016-03-08 14:40 +0100
Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag callback kbuild test robot <lkp@intel.com> - 2016-03-08 15:00 +0100
Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag callback Steven Rostedt <rostedt@goodmis.org> - 2016-03-08 15:20 +0100
Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag callback Steven Rostedt <rostedt@goodmis.org> - 2016-03-08 15:40 +0100
Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag callback Chunyu Hu <chuhu@redhat.com> - 2016-03-08 16:30 +0100
Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag callback Steven Rostedt <rostedt@goodmis.org> - 2016-03-08 16:40 +0100
Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag callback Steven Rostedt <rostedt@goodmis.org> - 2016-03-08 16:40 +0100
Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag callback Steven Rostedt <rostedt@goodmis.org> - 2016-03-08 16:40 +0100
Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag callback Steven Rostedt <rostedt@goodmis.org> - 2016-03-08 16:00 +0100
Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag callback Steven Rostedt <rostedt@goodmis.org> - 2016-03-08 16:20 +0100
Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag callback Chunyu Hu <chuhu@redhat.com> - 2016-03-08 17:00 +0100
Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag callback Steven Rostedt <rostedt@goodmis.org> - 2016-03-08 17:30 +0100
Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag callback Chunyu Hu <chuhu@redhat.com> - 2016-03-09 14:40 +0100
Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag callback Steven Rostedt <rostedt@goodmis.org> - 2016-03-09 15:00 +0100
csiph-web