Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1351993

RE: [PATCH RESEND] qib:Fix concurrent access in the function, qib_init_iba6120_funcs

Show all headers | View raw

> From: nick [mailto:xerofoify@gmail.com]
> Sent: Monday, March 7, 2016 2:21 PM
> To: Marciniszyn, Mike <mike.marciniszyn@intel.com>
> Cc: dledford@redhat.com; Hefty, Sean <sean.hefty@intel.com>;
> hal.rosenstock@gmail.com; linux-rdma@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH RESEND] qib:Fix concurrent access in the function,
> qib_init_iba6120_funcs
> 
> 
> 
> On 2016-03-07 11:34 AM, Marciniszyn, Mike wrote:
> >> This fixes concurrent access in the function, qib_init_iba6120_funcs
> >> by locking around the calls to when setting up f_sendctrl and
> >> f_set_armlauch function pointers to the functions, sendctrl_6120_mod
> >> qib_set_6120_armlaunch due to these functions needing to have their
> >> caller to hold the spinlock that is part of the qib_ibport pointer
> >> they are using and due to the lock not being held by higher up
> >> functions in the caller stack we need to hold it in qib_init_iba6210 to avoid
> conncurrent access when setting up these function pointers.
> >>
> >
> > I'm not sure I agree.
> >
> > static struct pci_driver qib_driver = {
> >         .name = QIB_DRV_NAME,
> >         .probe = qib_init_one,
> >         .remove = qib_remove_one,
> >         .id_table = qib_pci_tbl,
> >         .err_handler = &qib_pci_err_handler, };
> >
> > The only caller is the probe function, which naturally protects since the device
> cannot be used until the probe returns.
> >
> That's correct my concern was about threads from other kernel contexts but
> then again that's probably me being too conservative about critical region
> protection.
> Cheers,
> Nick

Doug, I'm NAKing this patch based on this reply from Nick.

Given that function vectors cannot be used until the qib_init_iba6120_funcs() functions return, this patch just not needed.

Mike

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

RE: [PATCH RESEND] qib:Fix concurrent access in the function,  qib_init_iba6120_funcs "Marciniszyn, Mike" <mike.marciniszyn@intel.com> - 2016-03-07 17:40 +0100
  Re: [PATCH RESEND] qib:Fix concurrent access in the function,  qib_init_iba6120_funcs Leon Romanovsky <leon@leon.nu> - 2016-03-07 22:00 +0100
  RE: [PATCH RESEND] qib:Fix concurrent access in the function,  qib_init_iba6120_funcs "Marciniszyn, Mike" <mike.marciniszyn@intel.com> - 2016-03-07 22:20 +0100

csiph-web