Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1351782

RE: [PATCH RESEND] qib:Fix concurrent access in the function, qib_init_iba6120_funcs

Show all headers | View raw

> This fixes concurrent access in the function, qib_init_iba6120_funcs by locking
> around the calls to when setting up f_sendctrl and f_set_armlauch function
> pointers to the functions, sendctrl_6120_mod qib_set_6120_armlaunch due to
> these functions needing to have their caller to hold the spinlock that is part of
> the qib_ibport pointer they are using and due to the lock not being held by
> higher up functions in the caller stack we need to hold it in qib_init_iba6210 to
> avoid conncurrent access when setting up these function pointers.
> 

I'm not sure I agree.

static struct pci_driver qib_driver = {
        .name = QIB_DRV_NAME,
        .probe = qib_init_one,
        .remove = qib_remove_one,
        .id_table = qib_pci_tbl,
        .err_handler = &qib_pci_err_handler,
};

The only caller is the probe function, which naturally protects since the device cannot be used until the probe returns.

Are you actually having an issue with this older version of a qib card?

The other board specific routines if this indeed is an issue, would need to be fixed as well since that have the same chip specific routine.

Mike

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

RE: [PATCH RESEND] qib:Fix concurrent access in the function,  qib_init_iba6120_funcs "Marciniszyn, Mike" <mike.marciniszyn@intel.com> - 2016-03-07 17:40 +0100
  Re: [PATCH RESEND] qib:Fix concurrent access in the function,  qib_init_iba6120_funcs Leon Romanovsky <leon@leon.nu> - 2016-03-07 22:00 +0100
  RE: [PATCH RESEND] qib:Fix concurrent access in the function,  qib_init_iba6120_funcs "Marciniszyn, Mike" <mike.marciniszyn@intel.com> - 2016-03-07 22:20 +0100

csiph-web