Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1451032

Re: [PATCH v2 2/4] arm64: dts: rockchip: add the saradc for rk3399

From Doug Anderson <dianders@chromium.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2 2/4] arm64: dts: rockchip: add the saradc for rk3399
Date 2016-07-27 06:10 +0200
Message-ID <rZokp-2TG-7@gated-at.bofh.it> (permalink)
References <rZ9v3-1PL-9@gated-at.bofh.it> <rZ9v4-1PL-35@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi,


On Tue, Jul 26, 2016 at 5:13 AM, Caesar Wang <wxt@rock-chips.com> wrote:
> This patch adds saradc needed information on rk3399 SoCs.
>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> ---
>
> Changes in v2: None
>
>  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index 4c84229..b81f84b 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -299,6 +299,18 @@
>                 };
>         };
>
> +       saradc: saradc@ff100000 {
> +               compatible = "rockchip,rk3399-saradc";
> +               reg = <0x0 0xff100000 0x0 0x100>;
> +               interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
> +               #io-channel-cells = <1>;
> +               clocks = <&cru SCLK_SARADC>, <&cru PCLK_SARADC>;
> +               clock-names = "saradc", "apb_pclk";
> +               resets = <&cru SRST_P_SARADC>;
> +               reset-names = "saradc-apb";
> +               status = "disabled";
> +       };
> +

Seems reasonable to me.  I'll let Heiko comment if he cares about the
sort ordering.  I can never quite figure out what it should be so I've
sorta given up on it...  ;)

Reviewed-by: Douglas Anderson <dianders@chromium.org>

-Doug

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it Caesar Wang <wxt@rock-chips.com> - 2016-07-26 14:20 +0200
  [PATCH v2 3/4] arm64: dts: rockchip: add reset saradc node for rk3368 SoCs Caesar Wang <wxt@rock-chips.com> - 2016-07-26 14:20 +0200
  [PATCH v2 2/4] arm64: dts: rockchip: add the saradc for rk3399 Caesar Wang <wxt@rock-chips.com> - 2016-07-26 14:20 +0200
    Re: [PATCH v2 2/4] arm64: dts: rockchip: add the saradc for rk3399 Doug Anderson <dianders@chromium.org> - 2016-07-27 06:10 +0200
  Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller  before programming it Guenter Roeck <linux@roeck-us.net> - 2016-07-26 15:50 +0200
    Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller  before programming it Caesar Wang <wxt@rock-chips.com> - 2016-07-26 16:50 +0200
      Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc  controller before programming it Guenter Roeck <linux@roeck-us.net> - 2016-07-26 19:10 +0200
        Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller  before programming it Caesar Wang <wxt@rock-chips.com> - 2016-07-27 02:50 +0200
          Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller  before programming it Guenter Roeck <linux@roeck-us.net> - 2016-07-27 04:10 +0200
            Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller  before programming it Caesar Wang <wxt@rock-chips.com> - 2016-07-27 04:20 +0200
  Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc  controller before programming it Guenter Roeck <linux@roeck-us.net> - 2016-07-27 00:50 +0200
  Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc  controller before programming it Rob Herring <robh@kernel.org> - 2016-07-27 17:20 +0200

csiph-web