Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1451001

Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it

Show all headers | View raw

On 07/26/2016 05:42 PM, Caesar Wang wrote:
>
> On 2016年07月27日 01:00, Guenter Roeck wrote:
>> On Tue, Jul 26, 2016 at 10:47:16PM +0800, Caesar Wang wrote:
>>> On 2016年07月26日 21:39, Guenter Roeck wrote:
>>>>> static int rockchip_saradc_probe(struct platform_device *pdev)
>>>>> {
>>>>> struct rockchip_saradc *info = NULL;
>>>>> @@ -218,6 +231,21 @@ static int rockchip_saradc_probe(struct
>>>>> platform_device *pdev)
>>>>> if (IS_ERR(info->regs))
>>>>> return PTR_ERR(info->regs);
>>>>>
>>>>> + /*
>>>>> + * The reset should be an optional property, as it should work
>>>>> + * with old devicetrees as well
>>>>> + */
>>>>> + info->reset = devm_reset_control_get_optional(&pdev->dev,
>>>>> + "saradc-apb");
>>>> Does anyone know what the _optional API is for ? It seems to be exactly
>>>> the same
>>>> as devm_reset_control_get().
>>> “
>>> As far as I see, the difference is WARN_ON(1)
>>> when CONFIG_RESET_CONTROLLER is not defined.
>>>
>>>
>>> The _optional functions were introduced by the following commit:
>>>
>>> ----------------->8-----------------
>>> commit b424080a9e086e683ad5fdc624a7cf3c024e0c0f
>>> Author: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
>>> Date: Fri Mar 7 15:18:47 2014 +0100
>>>
>>> reset: Add optional resets and stubs
>>>
>>> This patch adds device_reset_optional and (devm_)reset_control_get_optional
>>> variants that drivers can use to indicate they can function without control
>>> over the reset line. For those functions, stubs are added so the drivers can
>>> be compiled with CONFIG_RESET_CONTROLLER disabled.
>>> Also, device_reset is annotated with __must_check. Drivers
>>> ignoring the return
>>> value should use device_reset_optional instead.
>>>
>> Is that really what we are looking for here ? CONFIG_RESET_CONTROLLER
>> is required for other functions of rk3399, isn't it ?
>
> Right, as the DRM and thermal are depend on the CONFIG_RESET_CONTROLLER .....
>

Since "optional" doesn't really mean "the reset property is optional"
but "CONFIG_RESET_CONTROLLER is optional", I would suggest to use
devm_reset_control_get().

Guenter

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it Caesar Wang <wxt@rock-chips.com> - 2016-07-26 14:20 +0200
  [PATCH v2 3/4] arm64: dts: rockchip: add reset saradc node for rk3368 SoCs Caesar Wang <wxt@rock-chips.com> - 2016-07-26 14:20 +0200
  [PATCH v2 2/4] arm64: dts: rockchip: add the saradc for rk3399 Caesar Wang <wxt@rock-chips.com> - 2016-07-26 14:20 +0200
    Re: [PATCH v2 2/4] arm64: dts: rockchip: add the saradc for rk3399 Doug Anderson <dianders@chromium.org> - 2016-07-27 06:10 +0200
  Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller  before programming it Guenter Roeck <linux@roeck-us.net> - 2016-07-26 15:50 +0200
    Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller  before programming it Caesar Wang <wxt@rock-chips.com> - 2016-07-26 16:50 +0200
      Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc  controller before programming it Guenter Roeck <linux@roeck-us.net> - 2016-07-26 19:10 +0200
        Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller  before programming it Caesar Wang <wxt@rock-chips.com> - 2016-07-27 02:50 +0200
          Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller  before programming it Guenter Roeck <linux@roeck-us.net> - 2016-07-27 04:10 +0200
            Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller  before programming it Caesar Wang <wxt@rock-chips.com> - 2016-07-27 04:20 +0200
  Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc  controller before programming it Guenter Roeck <linux@roeck-us.net> - 2016-07-27 00:50 +0200
  Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc  controller before programming it Rob Herring <robh@kernel.org> - 2016-07-27 17:20 +0200

csiph-web