Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1451990

Re: [PATCH] ASoC: rt5659: Add mclk controls

From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] ASoC: rt5659: Add mclk controls
Date 2016-07-28 18:00 +0200
Message-ID <rZVT4-8jp-15@gated-at.bofh.it> (permalink)
References <rZG7D-62u-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Wed, Jul 27, 2016 at 04:02:48PM -0700, Nicolin Chen wrote:

> The codec driver should control the mclk. So this patch adds this support.

> +	/* Check if MCLK provided */
> +	rt5659->mclk = devm_clk_get(&i2c->dev, "mclk");
> +	if (IS_ERR(rt5659->mclk)) {
> +		if (PTR_ERR(rt5659->mclk) == -EPROBE_DEFER)
> +			return -EPROBE_DEFER;
> +		/* Otherwise mark the mclk pointer to NULL */
> +		rt5659->mclk = NULL;
> +	}

This device seems to be used on x86 systems so we'll need to ensure that
they register clocks for this.  They really should set this up using
quirks keyed off DMI information or similar so it's hidden from other
systems.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] ASoC: rt5659: Add mclk controls Nicolin Chen <nicoleotsuka@gmail.com> - 2016-07-28 01:10 +0200
  Re: [PATCH] ASoC: rt5659: Add mclk controls Mark Brown <broonie@kernel.org> - 2016-07-28 18:00 +0200
    Re: [PATCH] ASoC: rt5659: Add mclk controls Nicolin Chen <nicoleotsuka@gmail.com> - 2016-07-28 20:20 +0200
      Re: [PATCH] ASoC: rt5659: Add mclk controls Mark Brown <broonie@kernel.org> - 2016-07-28 21:00 +0200
        Re: [PATCH] ASoC: rt5659: Add mclk controls Nicolin Chen <nicoleotsuka@gmail.com> - 2016-07-28 21:10 +0200
        Re: [PATCH] ASoC: rt5659: Add mclk controls Vinod Koul <vinod.koul@intel.com> - 2016-07-29 18:10 +0200
          Re: [PATCH] ASoC: rt5659: Add mclk controls Mark Brown <broonie@kernel.org> - 2016-07-29 18:50 +0200
            Re: [alsa-devel] [PATCH] ASoC: rt5659: Add mclk controls Vinod Koul <vinod.koul@intel.com> - 2016-07-29 18:50 +0200
            Re: [alsa-devel] [PATCH] ASoC: rt5659: Add mclk controls Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> - 2016-08-10 21:00 +0200
              Re: [alsa-devel] [PATCH] ASoC: rt5659: Add mclk controls Mark Brown <broonie@kernel.org> - 2016-08-10 21:10 +0200
            Re: [alsa-devel] [PATCH] ASoC: rt5659: Add mclk controls Mark Brown <broonie@kernel.org> - 2016-08-10 21:00 +0200
            Re: [alsa-devel] [PATCH] ASoC: rt5659: Add mclk controls Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> - 2016-08-10 22:10 +0200
  Re: [alsa-devel] [PATCH] ASoC: rt5659: Add mclk controls Lars-Peter Clausen <lars@metafoo.de> - 2016-07-28 22:50 +0200
    Re: [alsa-devel] [PATCH] ASoC: rt5659: Add mclk controls Nicolin Chen <nicoleotsuka@gmail.com> - 2016-07-28 23:00 +0200

csiph-web