Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1452099
| From | Nicolin Chen <nicoleotsuka@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [alsa-devel] [PATCH] ASoC: rt5659: Add mclk controls |
| Date | 2016-07-28 23:00 +0200 |
| Message-ID | <s00zo-2ZP-5@gated-at.bofh.it> (permalink) |
| References | <rZG7D-62u-21@gated-at.bofh.it> <s00pI-2VK-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jul 28, 2016 at 10:40:44PM +0200, Lars-Peter Clausen wrote:
> > + /* Check if MCLK provided */
> > + rt5659->mclk = devm_clk_get(&i2c->dev, "mclk");
> > + if (IS_ERR(rt5659->mclk)) {
> > + if (PTR_ERR(rt5659->mclk) == -EPROBE_DEFER)
> > + return -EPROBE_DEFER;
>
> The correct thing to do here is to check if != -ENOENT and then return
> the error code. Otherwise you silently ignore errors if a clock was
> specified, but there was an error requesting it.
Oh..Thanks for the input. Will refine it in v2.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] ASoC: rt5659: Add mclk controls Nicolin Chen <nicoleotsuka@gmail.com> - 2016-07-28 01:10 +0200
Re: [PATCH] ASoC: rt5659: Add mclk controls Mark Brown <broonie@kernel.org> - 2016-07-28 18:00 +0200
Re: [PATCH] ASoC: rt5659: Add mclk controls Nicolin Chen <nicoleotsuka@gmail.com> - 2016-07-28 20:20 +0200
Re: [PATCH] ASoC: rt5659: Add mclk controls Mark Brown <broonie@kernel.org> - 2016-07-28 21:00 +0200
Re: [PATCH] ASoC: rt5659: Add mclk controls Nicolin Chen <nicoleotsuka@gmail.com> - 2016-07-28 21:10 +0200
Re: [PATCH] ASoC: rt5659: Add mclk controls Vinod Koul <vinod.koul@intel.com> - 2016-07-29 18:10 +0200
Re: [PATCH] ASoC: rt5659: Add mclk controls Mark Brown <broonie@kernel.org> - 2016-07-29 18:50 +0200
Re: [alsa-devel] [PATCH] ASoC: rt5659: Add mclk controls Vinod Koul <vinod.koul@intel.com> - 2016-07-29 18:50 +0200
Re: [alsa-devel] [PATCH] ASoC: rt5659: Add mclk controls Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> - 2016-08-10 21:00 +0200
Re: [alsa-devel] [PATCH] ASoC: rt5659: Add mclk controls Mark Brown <broonie@kernel.org> - 2016-08-10 21:10 +0200
Re: [alsa-devel] [PATCH] ASoC: rt5659: Add mclk controls Mark Brown <broonie@kernel.org> - 2016-08-10 21:00 +0200
Re: [alsa-devel] [PATCH] ASoC: rt5659: Add mclk controls Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> - 2016-08-10 22:10 +0200
Re: [alsa-devel] [PATCH] ASoC: rt5659: Add mclk controls Lars-Peter Clausen <lars@metafoo.de> - 2016-07-28 22:50 +0200
Re: [alsa-devel] [PATCH] ASoC: rt5659: Add mclk controls Nicolin Chen <nicoleotsuka@gmail.com> - 2016-07-28 23:00 +0200
csiph-web