Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1445314

Re: [patch] crypto: sha256-mb - cleanup a || vs | typo

From Pavel Machek <pavel@ucw.cz>
Newsgroups linux.kernel
Subject Re: [patch] crypto: sha256-mb - cleanup a || vs | typo
Date 2016-07-18 11:00 +0200
Message-ID <rWcz8-3YY-13@gated-at.bofh.it> (permalink)
References (4 earlier) <rQ2VQ-4RO-23@gated-at.bofh.it> <rQ4Eh-5XI-3@gated-at.bofh.it> <rSGP7-79Y-1@gated-at.bofh.it> <rSH8u-7ja-27@gated-at.bofh.it> <rSHBw-7JO-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri 2016-07-08 10:19:26, Linus Torvalds wrote:
> [ rare comment rant. I think I'll do this once, and then ignore the discussion ]
> 
> On Fri, Jul 8, 2016 at 9:45 AM, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> >
> > Nack.  As I said the commenting style in the crypto API is the
> > same as the network stack.  So unless we decide to change both
> > please stick to the current style.
> 
> Can we please get rid of the brain-damaged stupid networking comment
> syntax style, PLEASE?

Please? :-). Having different comment styles between networking and
the rest is confusing.

And yes, this uglyness is documented for net/ and drivers/net/, but
not for crypto/, so at the very least Documentation/CodingStyle should
be updated.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

Re: [patch] crypto: sha256-mb - cleanup a || vs | typo Pavel Machek <pavel@ucw.cz> - 2016-07-18 11:00 +0200
  Re: [patch] crypto: sha256-mb - cleanup a || vs | typo Tim Chen <tim.c.chen@linux.intel.com> - 2016-07-19 00:20 +0200

csiph-web