Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1445314 > unrolled thread
| Started by | Pavel Machek <pavel@ucw.cz> |
|---|---|
| First post | 2016-07-18 11:00 +0200 |
| Last post | 2016-07-19 00:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [patch] crypto: sha256-mb - cleanup a || vs | typo Pavel Machek <pavel@ucw.cz> - 2016-07-18 11:00 +0200
Re: [patch] crypto: sha256-mb - cleanup a || vs | typo Tim Chen <tim.c.chen@linux.intel.com> - 2016-07-19 00:20 +0200
| From | Pavel Machek <pavel@ucw.cz> |
|---|---|
| Date | 2016-07-18 11:00 +0200 |
| Subject | Re: [patch] crypto: sha256-mb - cleanup a || vs | typo |
| Message-ID | <rWcz8-3YY-13@gated-at.bofh.it> |
On Fri 2016-07-08 10:19:26, Linus Torvalds wrote: > [ rare comment rant. I think I'll do this once, and then ignore the discussion ] > > On Fri, Jul 8, 2016 at 9:45 AM, Herbert Xu <herbert@gondor.apana.org.au> wrote: > > > > Nack. As I said the commenting style in the crypto API is the > > same as the network stack. So unless we decide to change both > > please stick to the current style. > > Can we please get rid of the brain-damaged stupid networking comment > syntax style, PLEASE? Please? :-). Having different comment styles between networking and the rest is confusing. And yes, this uglyness is documented for net/ and drivers/net/, but not for crypto/, so at the very least Documentation/CodingStyle should be updated. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[toc] | [next] | [standalone]
| From | Tim Chen <tim.c.chen@linux.intel.com> |
|---|---|
| Date | 2016-07-19 00:20 +0200 |
| Message-ID | <rWp3k-3J6-25@gated-at.bofh.it> |
| In reply to | #1445314 |
On Mon, 2016-07-18 at 10:59 +0200, Pavel Machek wrote: > On Fri 2016-07-08 10:19:26, Linus Torvalds wrote: > > > > [ rare comment rant. I think I'll do this once, and then ignore the discussion ] > > > > On Fri, Jul 8, 2016 at 9:45 AM, Herbert Xu <herbert@gondor.apana.org.au> wrote: > > > > > > > > > Nack. As I said the commenting style in the crypto API is the > > > same as the network stack. So unless we decide to change both > > > please stick to the current style. > > Can we please get rid of the brain-damaged stupid networking comment > > syntax style, PLEASE? > Please? :-). Having different comment styles between networking and > the rest is confusing. > > And yes, this uglyness is documented for net/ and drivers/net/, but > not for crypto/, so at the very least Documentation/CodingStyle should > be updated. > > Pavel The cleanup patch has already been merged. Thanks. Tim
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web