Re: [PATCH 07/16] gpu: ipu-v3: Add VDI input IDMAC channels

From	Steve Longerbeam <steve_longerbeam@mentor.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 07/16] gpu: ipu-v3: Add VDI input IDMAC channels
Date	2016-07-15 23:40 +0200
Message-ID	<rViZX-3Bi-3@gated-at.bofh.it> (permalink)
References	<rSqAF-51z-3@gated-at.bofh.it> <rSqAG-51z-25@gated-at.bofh.it> <rVaJ4-6Xs-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 07/15/2016 05:45 AM, Philipp Zabel wrote:
> Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam:
>> Adds the VDIC field input IDMAC channels. These channels
>> transfer fields F(n-1), F(n), and F(N+1) from memory to
>> the VDIC (channels 8, 9, 10 respectively).
>>
>> Signed-off-by: Steve Longerbeam <steve_longerbeam@mentor.com>
>> ---
>>   include/video/imx-ipu-v3.h | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/include/video/imx-ipu-v3.h b/include/video/imx-ipu-v3.h
>> index 586979e..2302fc5 100644
>> --- a/include/video/imx-ipu-v3.h
>> +++ b/include/video/imx-ipu-v3.h
>> @@ -107,6 +107,9 @@ enum ipu_channel_irq {
>>   #define IPUV3_CHANNEL_CSI2			 2
>>   #define IPUV3_CHANNEL_CSI3			 3
>>   #define IPUV3_CHANNEL_VDI_MEM_IC_VF		 5
>> +#define IPUV3_CHANNEL_MEM_VDI_P			 8
>> +#define IPUV3_CHANNEL_MEM_VDI			 9
>> +#define IPUV3_CHANNEL_MEM_VDI_N			10
> I would prefer the names to be just a bit more descriptive:
>
> #define IPUV3_CHANNEL_MEM_VDI_PREV		 8
> #define IPUV3_CHANNEL_MEM_VDI_CUR		 9
> #define IPUV3_CHANNEL_MEM_VDI_NEXT		10
>
> The reference manual states that the purposes of these channels are
> "Previous field", "Current field", and "Next field" input to the VDIC,
> respectively.

right. Ok I will make that change in next version.

Steve

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 07/16] gpu: ipu-v3: Add VDI input IDMAC channels Philipp Zabel <p.zabel@pengutronix.de> - 2016-07-15 14:50 +0200
  Re: [PATCH 07/16] gpu: ipu-v3: Add VDI input IDMAC channels Steve Longerbeam <steve_longerbeam@mentor.com> - 2016-07-15 23:40 +0200

csiph-web