Path: csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod From: Steve Longerbeam Newsgroups: linux.kernel Subject: Re: [PATCH 07/16] gpu: ipu-v3: Add VDI input IDMAC channels Date: Fri, 15 Jul 2016 23:40:01 +0200 Message-ID: References: X-Original-To: Philipp Zabel , Steve Longerbeam User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 37 Organization: linux.* mail to news gateway X-Original-Cc: , X-Original-Date: Fri, 15 Jul 2016 14:34:07 -0700 X-Original-Message-ID: <578956CF.9020801@mentor.com> X-Original-References: <1467932621-358-1-git-send-email-steve_longerbeam@mentor.com> <1467932621-358-8-git-send-email-steve_longerbeam@mentor.com> <1468586749.7213.33.camel@pengutronix.de> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1444608 On 07/15/2016 05:45 AM, Philipp Zabel wrote: > Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam: >> Adds the VDIC field input IDMAC channels. These channels >> transfer fields F(n-1), F(n), and F(N+1) from memory to >> the VDIC (channels 8, 9, 10 respectively). >> >> Signed-off-by: Steve Longerbeam >> --- >> include/video/imx-ipu-v3.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/include/video/imx-ipu-v3.h b/include/video/imx-ipu-v3.h >> index 586979e..2302fc5 100644 >> --- a/include/video/imx-ipu-v3.h >> +++ b/include/video/imx-ipu-v3.h >> @@ -107,6 +107,9 @@ enum ipu_channel_irq { >> #define IPUV3_CHANNEL_CSI2 2 >> #define IPUV3_CHANNEL_CSI3 3 >> #define IPUV3_CHANNEL_VDI_MEM_IC_VF 5 >> +#define IPUV3_CHANNEL_MEM_VDI_P 8 >> +#define IPUV3_CHANNEL_MEM_VDI 9 >> +#define IPUV3_CHANNEL_MEM_VDI_N 10 > I would prefer the names to be just a bit more descriptive: > > #define IPUV3_CHANNEL_MEM_VDI_PREV 8 > #define IPUV3_CHANNEL_MEM_VDI_CUR 9 > #define IPUV3_CHANNEL_MEM_VDI_NEXT 10 > > The reference manual states that the purposes of these channels are > "Previous field", "Current field", and "Next field" input to the VDIC, > respectively. right. Ok I will make that change in next version. Steve