Re: [PATCH net] net: cavium: liquidio: Avoid dma_unmap_single on uninitialized ndata

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH net] net: cavium: liquidio: Avoid dma_unmap_single on uninitialized ndata
Date	2016-07-17 07:10 +0200
Message-ID	<rVMuZ-538-5@gated-at.bofh.it> (permalink)
References	<rVl1M-4Mo-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Fri, 15 Jul 2016 16:42:16 -0700

> The label lio_xmit_failed is used 3 times through liquidio_xmit() but it
> always makes a call to dma_unmap_single() using potentially
> uninitialized variables from "ndata" variable. Out of the 3 gotos, 2 run
> after ndata has been initialized, and had a prior dma_map_single() call.
> 
> Fix this by adding a new error label: lio_xmit_dma_failed which does
> this dma_unmap_single() and then processed with the lio_xmit_failed
> fallthrough.
> 
> Fixes: f21fb3ed364bb ("Add support of Cavium Liquidio ethernet adapters")
> Reported-by: coverity (CID 1309740)
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net] net: cavium: liquidio: Avoid dma_unmap_single on uninitialized ndata Florian Fainelli <f.fainelli@gmail.com> - 2016-07-16 01:50 +0200
  Re: [PATCH net] net: cavium: liquidio: Avoid dma_unmap_single on  uninitialized ndata David Miller <davem@davemloft.net> - 2016-07-17 07:10 +0200

csiph-web