Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1445013
| From | David Miller <davem@davemloft.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net] et131x: Fix logical vs bitwise check in et131x_tx_timeout() |
| Date | 2016-07-17 07:10 +0200 |
| Message-ID | <rVMuZ-538-1@gated-at.bofh.it> (permalink) |
| References | <rVl1M-4Mo-35@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Fri, 15 Jul 2016 16:40:22 -0700
> We should be using a logical check here instead of a bitwise operation
> to check if the device is closed already in et131x_tx_timeout().
>
> Reported-by: coverity (CID 146498)
> Fixes: 38df6492eb511 ("et131x: Add PCIe gigabit ethernet driver et131x to drivers/net")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH net] et131x: Fix logical vs bitwise check in et131x_tx_timeout() Florian Fainelli <f.fainelli@gmail.com> - 2016-07-16 01:50 +0200 Re: [PATCH net] et131x: Fix logical vs bitwise check in et131x_tx_timeout() David Miller <davem@davemloft.net> - 2016-07-17 07:10 +0200
csiph-web