Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1443951
| From | Al Viro <viro@ZenIV.linux.org.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] staging: lustre: o2iblnd: iov fixes for kiblnd_send |
| Date | 2016-07-15 07:20 +0200 |
| Message-ID | <rV3HA-2Ms-15@gated-at.bofh.it> (permalink) |
| References | <rTN29-1BX-17@gated-at.bofh.it> <rV3xT-2IL-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Jul 15, 2016 at 01:01:35AM -0400, Oleg Drokin wrote:
> > + } else {
> > + iov_iter_kvec(&from, ITER_KVEC | WRITE,
> > + payload_iov, payload_niov,
> > + payload_nob + payload_offset);
> > + }
> > iov_iter_advance(&from, payload_offset);
>
> Ah, I guess we added it there to then subtract here?
Yes (and that actually fixes a real bug there).
> Do you mind if I just merge this change into Al's patch with you as another
> Signed-off-by line instead?
> Since we caught this early, probably no point in having a breakage point in
> the history as it might break a future bisect.
No objections from me. FWIW, I'd rather have all of that go through your
tree - it's independent from everything else in vfs.git and pulls quite
a bit from yours, so...
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] staging: lustre: o2iblnd: iov fixes for kiblnd_send James Simmons <jsimmons@infradead.org> - 2016-07-11 19:20 +0200
Re: [PATCH] staging: lustre: o2iblnd: iov fixes for kiblnd_send Oleg Drokin <oleg.drokin@intel.com> - 2016-07-15 07:10 +0200
Re: [PATCH] staging: lustre: o2iblnd: iov fixes for kiblnd_send Al Viro <viro@ZenIV.linux.org.uk> - 2016-07-15 07:20 +0200
Re: [PATCH] staging: lustre: o2iblnd: iov fixes for kiblnd_send James Simmons <jsimmons@infradead.org> - 2016-07-18 17:30 +0200
csiph-web