Re: [PATCH] mlxsw: spectrum_router: Return -ENOENT in case of error

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mlxsw: spectrum_router: Return -ENOENT in case of error
Date	2016-07-15 07:20 +0200
Message-ID	<rV3HA-2Ms-17@gated-at.bofh.it> (permalink)
References	<rUIa6-5Pz-25@gated-at.bofh.it> <rUIjL-5Tv-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Jiri Pirko <jiri@resnulli.us>
Date: Thu, 14 Jul 2016 08:28:19 +0200

> Thu, Jul 14, 2016 at 08:18:45AM CEST, christophe.jaillet@wanadoo.fr wrote:
>>'vr' should be a valid pointer here, so returning 'PTR_ERR(vr)' is wrong.
>>Return an explicit error code (-ENOENT) instead.
>>
> 
> This is fo net-next.
> 
> Fixes: 61c503f976 ("mlxsw: spectrum_router: Implement fib4 add/del switchdev obj ops")
> 
>>Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> 
> Acked-by: Jiri Pirko <jiri@mellanox.com>

Applied, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mlxsw: spectrum_router: Return -ENOENT in case of error Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-07-14 08:20 +0200
  Re: [PATCH] mlxsw: spectrum_router: Return -ENOENT in case of error Jiri Pirko <jiri@resnulli.us> - 2016-07-14 08:30 +0200
    Re: [PATCH] mlxsw: spectrum_router: Return -ENOENT in case of error David Miller <davem@davemloft.net> - 2016-07-15 07:20 +0200

csiph-web