Re: [PATCH] vfs: check i_count under lock in evict_inodes

From	Al Viro <viro@ZenIV.linux.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH] vfs: check i_count under lock in evict_inodes
Date	2016-07-12 07:30 +0200
Message-ID	<rTYqB-yl-1@gated-at.bofh.it> (permalink)
References	<rTTKh-5SH-5@gated-at.bofh.it> <rTU3E-607-7@gated-at.bofh.it> <rTUQ2-6xe-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jul 11, 2016 at 06:31:57PM -0700, David Chen wrote:
> Hi Al,
> 
> I'm not sure about the in-tree fs, but in zfsonlinux, it would offload
> iput to a thread, so this would happen there. And it would wait for
> the thread in put_super(), so that part is not a problem...

*shrug*  I hadn't looked (and won't look) at zfs glue, but I'd suggest
trying something along the line of stopping that thread in the beginning
of your ->kill_sb() (having told the sucker to stop offloading, of course)
and only then calling generic_shutdown_super()...

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] vfs: check i_count under lock in evict_inodes Chunwei Chen <david.chen@osnexus.com> - 2016-07-12 02:30 +0200
  Re: [PATCH] vfs: check i_count under lock in evict_inodes Al Viro <viro@ZenIV.linux.org.uk> - 2016-07-12 02:50 +0200
    Re: [PATCH] vfs: check i_count under lock in evict_inodes David Chen <david.chen@osnexus.com> - 2016-07-12 03:40 +0200
      Re: [PATCH] vfs: check i_count under lock in evict_inodes Christoph Hellwig <hch@infradead.org> - 2016-07-12 03:50 +0200
      Re: [PATCH] vfs: check i_count under lock in evict_inodes Al Viro <viro@ZenIV.linux.org.uk> - 2016-07-12 07:30 +0200

csiph-web