Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1440979

Re: [PATCH] drm/vc4: remove redundant ret status check

From Eric Anholt <eric@anholt.net>
Newsgroups linux.kernel
Subject Re: [PATCH] drm/vc4: remove redundant ret status check
Date 2016-07-12 02:30 +0200
Message-ID <rTTKh-5SH-3@gated-at.bofh.it> (permalink)
References <rT8V5-o0-49@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

Colin King <colin.king@canonical.com> writes:

> From: Colin Ian King <colin.king@canonical.com>
>
> At the current point where ret is being checked for non-zero it has
> not changed since it was initialized to zero, hence the check and the
> label unref are redundant and can be removed.

Reviewed-by: Eric Anholt <eric@anholt.net>

I'll put this in my next pull request.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] drm/vc4: remove redundant ret status check Eric Anholt <eric@anholt.net> - 2016-07-12 02:30 +0200

csiph-web