Re: [PATCH] drm/vc4: remove redundant ret status check

Path	csiph.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod
From	Eric Anholt <eric@anholt.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drm/vc4: remove redundant ret status check
Date	Tue, 12 Jul 2016 02:30:01 +0200
Message-ID	<rTTKh-5SH-3@gated-at.bofh.it> (permalink)
References	<rT8V5-o0-49@gated-at.bofh.it>
User-Agent	Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu)
MIME-Version	1.0
Content-Type	multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	36
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org
X-Original-Date	Mon, 11 Jul 2016 17:24:21 -0700
X-Original-Message-ID	<87zipn1z62.fsf@eliezer.anholt.net>
X-Original-References	<1468103163-6588-1-git-send-email-colin.king@canonical.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1440979

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Colin King <colin.king@canonical.com> writes:

> From: Colin Ian King <colin.king@canonical.com>
>
> At the current point where ret is being checked for non-zero it has
> not changed since it was initialized to zero, hence the check and the
> label unref are redundant and can be removed.

Reviewed-by: Eric Anholt <eric@anholt.net>

I'll put this in my next pull request.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] drm/vc4: remove redundant ret status check Eric Anholt <eric@anholt.net> - 2016-07-12 02:30 +0200

csiph-web