Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1440829

Re: [PATCH] include: mman: Use bool instead of int for the return value of arch_validate_prot

Show all headers | View raw

On 7/11/16 07:47, Dave Hansen wrote:
> On 07/09/2016 09:29 AM, chengang@emindsoft.com.cn wrote:
>> -static inline int arch_validate_prot(unsigned long prot)
>> +static inline bool arch_validate_prot(unsigned long prot)
>>  {
>>  	if (prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC | PROT_SEM | PROT_SAO))
>> -		return 0;
>> -	if ((prot & PROT_SAO) && !cpu_has_feature(CPU_FTR_SAO))
>> -		return 0;
>> -	return 1;
>> +		return false;
>> +	return (prot & PROT_SAO) == 0 || cpu_has_feature(CPU_FTR_SAO);
>>  }
>>  #define arch_validate_prot(prot) arch_validate_prot(prot)
> 
> Please don't do things like this.  They're not obviously correct and
> also have no obvious benefit.  You also don't mention why you bothered
> to alter the logical structure of these checks.
> 

For all cases, bool is equal or a little better than int, and they are
equal in our case (2 final outputs are same). So for me, it may belong
to trivial patch, which can be skipped by the normal patch maintainers.

As a 'trivial' patch:

 - For a pure Boolean function, bool return value is more readable than
   int.

 - If one statement can express the same expression, and is as simple as
   the original 'if' statement, one statement is better than 3 original
   statements.

 - In our case:

	if ((prot & PROT_SAO) && !cpu_has_feature(CPU_FTR_SAO))
		return 0;
	return 1;

   equal to:

	return !((prot & PROT_SAO) && !cpu_has_feature(CPU_FTR_SAO));

   equal to:

	return !(prot & PROT_SAO) || !!cpu_has_feature(CPU_FTR_SAO);

   then:

	return (prot & PROT_SAO) == 0 || cpu_has_feature(CPU_FTR_SAO);

Thanks
-- 
Chen Gang (陈刚)

Managing Natural Environments is the Duty of Human Beings.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] include: mman: Use bool instead of int for the return  value of arch_validate_prot Dave Hansen <dave.hansen@linux.intel.com> - 2016-07-11 01:50 +0200
  Re: [PATCH] include: mman: Use bool instead of int for the return  value of arch_validate_prot Chen Gang <chengang@emindsoft.com.cn> - 2016-07-11 21:10 +0200
    Re: [PATCH] include: mman: Use bool instead of int for the return  value of arch_validate_prot Chen Gang <chengang@emindsoft.com.cn> - 2016-07-12 18:50 +0200

csiph-web