Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1440185
| From | Dave Hansen <dave.hansen@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] include: mman: Use bool instead of int for the return value of arch_validate_prot |
| Date | 2016-07-11 01:50 +0200 |
| Message-ID | <rTwE2-7B3-5@gated-at.bofh.it> (permalink) |
| References | <rT3sm-5qj-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 07/09/2016 09:29 AM, chengang@emindsoft.com.cn wrote:
> -static inline int arch_validate_prot(unsigned long prot)
> +static inline bool arch_validate_prot(unsigned long prot)
> {
> if (prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC | PROT_SEM | PROT_SAO))
> - return 0;
> - if ((prot & PROT_SAO) && !cpu_has_feature(CPU_FTR_SAO))
> - return 0;
> - return 1;
> + return false;
> + return (prot & PROT_SAO) == 0 || cpu_has_feature(CPU_FTR_SAO);
> }
> #define arch_validate_prot(prot) arch_validate_prot(prot)
Please don't do things like this. They're not obviously correct and
also have no obvious benefit. You also don't mention why you bothered
to alter the logical structure of these checks.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] include: mman: Use bool instead of int for the return value of arch_validate_prot chengang@emindsoft.com.cn - 2016-07-09 18:40 +0200
Re: [PATCH] include: mman: Use bool instead of int for the return value of arch_validate_prot Dave Hansen <dave.hansen@linux.intel.com> - 2016-07-11 01:50 +0200
Re: [PATCH] include: mman: Use bool instead of int for the return value of arch_validate_prot Chen Gang <chengang@emindsoft.com.cn> - 2016-07-11 21:10 +0200
Re: [PATCH] include: mman: Use bool instead of int for the return value of arch_validate_prot Chen Gang <chengang@emindsoft.com.cn> - 2016-07-12 18:50 +0200
csiph-web