Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1439530

Re: [PATCH v14 3/8] perf tests: Add testcase for auxiliary evlist

From Jiri Olsa <jolsa@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH v14 3/8] perf tests: Add testcase for auxiliary evlist
Date 2016-07-08 16:50 +0200
Message-ID <rSFgl-64x-5@gated-at.bofh.it> (permalink)
References <rSacx-2D8-3@gated-at.bofh.it> <rSacy-2D8-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Jul 07, 2016 at 05:34:44AM +0000, Wang Nan wrote:

SNIP

>  	ret = TEST_FAIL;
> -	err = do_test(evlist, opts.mmap_pages, &sample_count,
> +	err = do_test(evlist, aux_evlist, opts.mmap_pages,
> +		      &enter_sample_count, &exit_sample_count,
>  		      &comm_count);
>  	if (err != TEST_OK)
>  		goto out_delete_evlist;
>  
> -	if ((sample_count != NR_ITERS) || (comm_count != NR_ITERS)) {
> -		pr_err("Unexpected counter: sample_count=%d, comm_count=%d\n",
> -		       sample_count, comm_count);
> +	if (enter_sample_count != exit_sample_count) {
> +		pr_err("Unexpected counter: enter_sample_count=%d, exit_sample_count=%d\n",
> +		       enter_sample_count, exit_sample_count);
> +		goto out_delete_evlist;
> +	}
> +
> +	if ((exit_sample_count != NR_ITERS) || (comm_count != NR_ITERS)) {
> +		pr_err("Unexpected counter: exit_sample_count=%d, comm_count=%d\n",
> +		       exit_sample_count, comm_count);
>  		goto out_delete_evlist;
>  	}
>  
> -	err = do_test(evlist, 1, &sample_count, &comm_count);
> +	err = do_test(evlist, aux_evlist, 1, &dummy, &dummy, &dummy);

why dont you test numbers for 1 page mmap?  seems like the data would fit..
is the purpose just to check if we can map just 1 page?

thanks,
jirka

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v14 0/8] perf tools: Support overwritable ring buffer Wang Nan <wangnan0@huawei.com> - 2016-07-07 07:40 +0200
  [PATCH v14 5/8] perf record: Read from overwritable ring buffer Wang Nan <wangnan0@huawei.com> - 2016-07-07 07:40 +0200
  [PATCH v14 7/8] perf tools: Don't warn about out of order event if write_backward is used Wang Nan <wangnan0@huawei.com> - 2016-07-07 07:40 +0200
  [PATCH v14 8/8] perf tools: Add --tail-synthesize option Wang Nan <wangnan0@huawei.com> - 2016-07-07 07:40 +0200
  [PATCH v14 2/8] perf evlist: Introduce aux evlist Wang Nan <wangnan0@huawei.com> - 2016-07-07 07:40 +0200
  [PATCH v14 1/8] perf tools: Drop redundant evsel->overwrite indicator Wang Nan <wangnan0@huawei.com> - 2016-07-07 07:40 +0200
  [PATCH v14 4/8] perf record: Introduce rec->overwrite_evlist for overwritable events Wang Nan <wangnan0@huawei.com> - 2016-07-07 07:40 +0200
    Re: [PATCH v14 4/8] perf record: Introduce rec->overwrite_evlist for  overwritable events Jiri Olsa <jolsa@redhat.com> - 2016-07-08 16:50 +0200
    Re: [PATCH v14 4/8] perf record: Introduce rec->overwrite_evlist for  overwritable events Jiri Olsa <jolsa@redhat.com> - 2016-07-08 16:50 +0200
  [PATCH v14 3/8] perf tests: Add testcase for auxiliary evlist Wang Nan <wangnan0@huawei.com> - 2016-07-07 07:40 +0200
    Re: [PATCH v14 3/8] perf tests: Add testcase for auxiliary evlist Jiri Olsa <jolsa@redhat.com> - 2016-07-08 16:50 +0200
      Re: [PATCH v14 3/8] perf tests: Add testcase for auxiliary evlist "Wangnan (F)" <wangnan0@huawei.com> - 2016-07-11 05:30 +0200
    Re: [PATCH v14 3/8] perf tests: Add testcase for auxiliary evlist Jiri Olsa <jolsa@redhat.com> - 2016-07-08 16:50 +0200
    Re: [PATCH v14 3/8] perf tests: Add testcase for auxiliary evlist Jiri Olsa <jolsa@redhat.com> - 2016-07-08 16:50 +0200

csiph-web