Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1439539
| From | Jiri Olsa <jolsa@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v14 4/8] perf record: Introduce rec->overwrite_evlist for overwritable events |
| Date | 2016-07-08 16:50 +0200 |
| Message-ID | <rSFgm-64x-33@gated-at.bofh.it> (permalink) |
| References | <rSacx-2D8-3@gated-at.bofh.it> <rSacy-2D8-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jul 07, 2016 at 05:34:45AM +0000, Wang Nan wrote:
SNIP
> + if (err)
> + return err;
> +
> + err = record__mmap_evlist(rec, rec->evlist, false);
> + if (err)
> + return err;
> +
> + if (!rec->overwrite_evlist)
> + return 0;
> +
> + err = record__mmap_evlist(rec, rec->overwrite_evlist, true);
> + if (err)
> + return err;
> + return 0;
> }
>
> static int record__open(struct record *rec)
> @@ -698,9 +743,14 @@ static const struct perf_event_mmap_page *record__pick_pc(struct record *rec)
> {
> const struct perf_event_mmap_page *pc;
>
> + /* Change it to a loop if a new aux evlist is added */
> pc = perf_evlist__pick_pc(rec->evlist);
> if (pc)
> return pc;
> + pc = perf_evlist__pick_pc(rec->overwrite_evlist);
> + if (pc)
> + return pc;
> +
> return NULL;
above 4 lines could be just:
return perf_evlist__pick_pc(rec->overwrite_evlist);
jirka
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v14 0/8] perf tools: Support overwritable ring buffer Wang Nan <wangnan0@huawei.com> - 2016-07-07 07:40 +0200
[PATCH v14 5/8] perf record: Read from overwritable ring buffer Wang Nan <wangnan0@huawei.com> - 2016-07-07 07:40 +0200
[PATCH v14 7/8] perf tools: Don't warn about out of order event if write_backward is used Wang Nan <wangnan0@huawei.com> - 2016-07-07 07:40 +0200
[PATCH v14 8/8] perf tools: Add --tail-synthesize option Wang Nan <wangnan0@huawei.com> - 2016-07-07 07:40 +0200
[PATCH v14 2/8] perf evlist: Introduce aux evlist Wang Nan <wangnan0@huawei.com> - 2016-07-07 07:40 +0200
[PATCH v14 1/8] perf tools: Drop redundant evsel->overwrite indicator Wang Nan <wangnan0@huawei.com> - 2016-07-07 07:40 +0200
[PATCH v14 4/8] perf record: Introduce rec->overwrite_evlist for overwritable events Wang Nan <wangnan0@huawei.com> - 2016-07-07 07:40 +0200
Re: [PATCH v14 4/8] perf record: Introduce rec->overwrite_evlist for overwritable events Jiri Olsa <jolsa@redhat.com> - 2016-07-08 16:50 +0200
Re: [PATCH v14 4/8] perf record: Introduce rec->overwrite_evlist for overwritable events Jiri Olsa <jolsa@redhat.com> - 2016-07-08 16:50 +0200
[PATCH v14 3/8] perf tests: Add testcase for auxiliary evlist Wang Nan <wangnan0@huawei.com> - 2016-07-07 07:40 +0200
Re: [PATCH v14 3/8] perf tests: Add testcase for auxiliary evlist Jiri Olsa <jolsa@redhat.com> - 2016-07-08 16:50 +0200
Re: [PATCH v14 3/8] perf tests: Add testcase for auxiliary evlist "Wangnan (F)" <wangnan0@huawei.com> - 2016-07-11 05:30 +0200
Re: [PATCH v14 3/8] perf tests: Add testcase for auxiliary evlist Jiri Olsa <jolsa@redhat.com> - 2016-07-08 16:50 +0200
Re: [PATCH v14 3/8] perf tests: Add testcase for auxiliary evlist Jiri Olsa <jolsa@redhat.com> - 2016-07-08 16:50 +0200
csiph-web