Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1439213

Re: [PATCH 3/6] x86/mce: Add support for new MCA_SYND register

Show all headers | View raw

* Borislav Petkov <bp@alien8.de> wrote:

> From: Yazen Ghannam <Yazen.Ghannam@amd.com>
> 
> Syndrome information is no longer contained in MCA_STATUS for SMCA
> systems but in a new register.
> 
> Add a synd field to struct mce to hold MCA_SYND register value. Add it
> to the end of struct mce to maintain compatibility with old versions of
> mcelog. Also, add it to the respective tracepoint.

>  /* AMD-specific bits */
> +#define MCI_STATUS_TCC		(1ULL<<55)  /* Task context corrupt */
> +#define MCI_STATUS_SYNDV	(1ULL<<53)  /* synd reg. valid */

> --- a/arch/x86/include/uapi/asm/mce.h
> +++ b/arch/x86/include/uapi/asm/mce.h
> @@ -26,6 +26,7 @@ struct mce {
>  	__u32 socketid;	/* CPU socket ID */
>  	__u32 apicid;	/* CPU initial apic ID */
>  	__u64 mcgcap;	/* MCGCAP MSR: machine check capabilities of CPU */
> +	__u64 synd;	/* MCA_SYND MSR: only valid on SMCA systems */
>  };

So why does neither the changelog nor the code comment actually _explain_ this and 
give aa bit of a background about what 'syndrome information' is and why we want 
to have kernel support for it?

This is why I hate kernel tooling that is not part of the kernel tree - the mcelog 
patch (hopefully ...) would tell us more about all this - but it's separate and 
this patch does not tell us anything ...

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] x86/RAS queue Borislav Petkov <bp@alien8.de> - 2016-07-08 11:10 +0200
  [PATCH 2/6] x86/RAS/AMD: Reduce number of IPIs when prepping error injection Borislav Petkov <bp@alien8.de> - 2016-07-08 11:20 +0200
    [tip:ras/core] x86/RAS/AMD: Reduce the number of IPIs when prepping  error injection tip-bot for Yazen Ghannam <tipbot@zytor.com> - 2016-07-08 14:10 +0200
  [PATCH 6/6] x86/RAS: Add syndrome support to mce_amd_inj Borislav Petkov <bp@alien8.de> - 2016-07-08 11:20 +0200
  [PATCH 5/6] EDAC, mce_amd: Print syndrome register value on SMCA systems Borislav Petkov <bp@alien8.de> - 2016-07-08 11:20 +0200
  [PATCH 3/6] x86/mce: Add support for new MCA_SYND register Borislav Petkov <bp@alien8.de> - 2016-07-08 11:20 +0200
    Re: [PATCH 3/6] x86/mce: Add support for new MCA_SYND register Ingo Molnar <mingo@kernel.org> - 2016-07-08 11:30 +0200
      Re: [PATCH 3/6] x86/mce: Add support for new MCA_SYND register Borislav Petkov <bp@alien8.de> - 2016-07-08 11:40 +0200
        Re: [PATCH 3/6] x86/mce: Add support for new MCA_SYND register Ingo Molnar <mingo@kernel.org> - 2016-07-08 11:50 +0200
          Re: [PATCH 3/6] x86/mce: Add support for new MCA_SYND register Borislav Petkov <bp@alien8.de> - 2016-07-08 12:20 +0200
            Re: [PATCH 3/6] x86/mce: Add support for new MCA_SYND register Ingo Molnar <mingo@kernel.org> - 2016-07-08 12:30 +0200
              Re: [PATCH 3/6] x86/mce: Add support for new MCA_SYND register Borislav Petkov <bp@alien8.de> - 2016-07-08 12:50 +0200
  [PATCH 1/6] x86/mce/AMD: Increase size of bank_map type Borislav Petkov <bp@alien8.de> - 2016-07-08 11:20 +0200
    Re: [PATCH 1/6] x86/mce/AMD: Increase size of bank_map type Ingo Molnar <mingo@kernel.org> - 2016-07-08 11:30 +0200
      Re: [PATCH 1/6] x86/mce/AMD: Increase size of bank_map type Borislav Petkov <bp@alien8.de> - 2016-07-08 11:40 +0200
    [tip:ras/core] x86/mce/AMD: Increase size of the bank_map type tip-bot for Aravind Gopalakrishnan <tipbot@zytor.com> - 2016-07-08 14:10 +0200
  [PATCH 4/6] x86/mce: Fix mce_rdmsrl() warning message Borislav Petkov <bp@alien8.de> - 2016-07-08 11:20 +0200
    [tip:ras/core] x86/mce: Fix mce_rdmsrl() warning message tip-bot for Borislav Petkov <tipbot@zytor.com> - 2016-07-08 14:10 +0200

csiph-web