Re: [PATCH -next] orangefs: use vzalloc() instead of vmalloc()/memset(0)

From	Mike Marshall <hubcap@omnibond.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH -next] orangefs: use vzalloc() instead of vmalloc()/memset(0)
Date	2016-07-06 21:10 +0200
Message-ID	<rS0mR-4Im-7@gated-at.bofh.it> (permalink)
References	<rRV3P-1jb-15@gated-at.bofh.it> <rRYO5-3Ee-7@gated-at.bofh.it> <rRZ7s-3Lq-3@gated-at.bofh.it> <rRZqO-47a-23@gated-at.bofh.it> <rRZAt-4ax-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Joe> That's incorrect.

<blush>... you are right. They mostly return -ENOMEM, but they
mostly don't print an error message. I like printing an error message
when I resolve to an error... a whole bunch of that function is sanity
checking input from userspace, with a specific error message for
any particular failure.

Joe> I don't see how that matters here as there's
Joe> already an OOM on v.alloc failure.

I'd find that if needed, but the first place I'd look when investigating
an Orangefs failure would be the Orangefs logs...

-Mike

On Wed, Jul 6, 2016 at 2:11 PM, Joe Perches <joe@perches.com> wrote:
> On Wed, 2016-07-06 at 14:00 -0400, Mike Marshall wrote:
>> Hi Joe...
>
> Hi Mike.
>
>> I looked around at other code to see how they were using vzalloc...
>> even if it is just the caller of the function that uses vzalloc, most
>> fs's that use vzalloc print an error message when vzalloc fails...
>
> That's incorrect.
>
> There are 72 v.alloc calls in fs/
> 2 of those calls have a specific OOM message.
> There's 1 in reiserfs (old and unsupported) and 1 in orangefs
>
>>  I sure do
>> like to follow the flow of our kernel module all in one place
>> with the gossip statements...
>
> I don't see how that matters here as there's
> already an OOM on v.alloc failure.
>
> cheers, Joe

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH -next] orangefs: use vzalloc() instead of vmalloc()/memset(0) weiyj_lk@163.com - 2016-07-06 15:30 +0200
  Re: [PATCH -next] orangefs: use vzalloc() instead of vmalloc()/memset(0) Mike Marshall <hubcap@omnibond.com> - 2016-07-06 19:30 +0200
    Re: [PATCH -next] orangefs: use vzalloc() instead of  vmalloc()/memset(0) Joe Perches <joe@perches.com> - 2016-07-06 19:50 +0200
      Re: [PATCH -next] orangefs: use vzalloc() instead of vmalloc()/memset(0) Mike Marshall <hubcap@omnibond.com> - 2016-07-06 20:10 +0200
        Re: [PATCH -next] orangefs: use vzalloc() instead of  vmalloc()/memset(0) Joe Perches <joe@perches.com> - 2016-07-06 20:20 +0200
          Re: [PATCH -next] orangefs: use vzalloc() instead of vmalloc()/memset(0) Mike Marshall <hubcap@omnibond.com> - 2016-07-06 21:10 +0200

csiph-web