Re: [PATCH -next] orangefs: use vzalloc() instead of vmalloc()/memset(0)

Path	csiph.com!news.redatomik.org!newsfeed.datemas.de!feeder2.usenet.farm!feeder1.xsusenet.com!nntpspool.opticnetworks.net!nntpspool01.opticnetworks.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Mike Marshall <hubcap@omnibond.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH -next] orangefs: use vzalloc() instead of vmalloc()/memset(0)
Date	Wed, 06 Jul 2016 21:10:01 +0200
Message-ID	<rS0mR-4Im-7@gated-at.bofh.it> (permalink)
References	<rRV3P-1jb-15@gated-at.bofh.it> <rRYO5-3Ee-7@gated-at.bofh.it> <rRZ7s-3Lq-3@gated-at.bofh.it> <rRZqO-47a-23@gated-at.bofh.it> <rRZAt-4ax-1@gated-at.bofh.it>
X-Original-To	Joe Perches <joe@perches.com>, Mike Marshall <hubcap@omnibond.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=omnibond-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=0nRcjcYwIj7LcC8EdnuIeTmLjTRUuMK3e4bvB76D7WM=; b=O3KKsk7r+aX/UV1DnoXrOn0amyS/+Ls9CH+sUOd4QdNEkHk2fjMx4unIztorbTEjdp Ojf/gRMAJ/A3DzmowKSUv0eGWRoyRK+9FEfFFzHrDP6qsscCw+CHaWg2b03UbPPKxtlr tseKGvdMCPfxXSb+xTsB4vs69pq91XNxdczALHVf6VynvkZQ599401py9CekBRm1j8O4 KC2pgX1Q4R6T/F6UBayWkHttq4MjM6cEmhmX1WR3qg+o9gmmtw5WkausM+P1/N/5boBw dK0K5Z/1Dg7kC/yHB0vHXSfy9Fb+IF4IjGgrn12N34cnVHnnU8xusEFrgl0BpSYk1SoG hNXA==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=0nRcjcYwIj7LcC8EdnuIeTmLjTRUuMK3e4bvB76D7WM=; b=PxxUJvrc/Elsp6fWP7COUIvWfNddaO/opjOScuVlvXrXNXsuj9OG7gvu8d9ojCbktS 4yBm5h0fgzkrJ7s/zetdgmh4rS96hdRoKm8DdCK930hCV/0h/LN7hZ16QvrR8TH+G4wj Y2Rt++xjBczDp6DNlF44OAYEOOSpA5ys0ZhbFKQEfV/vEDe9EyLF4eGS5+Uv3T+Dwfiq v8qEyHwPSe4oMVEbZTx+jqt5Cqy6kFrCfXwKoFajJFnE4EOz86RbxgqaU7aT0IFbWDgn yQaGLkQiBX/yz4fM0u+6H8Gccgu3d8zQlti0qsnoEfAWDmZN9EJm5QTilFoz1tsdOId4 RU8A==
X-Gm-Message-State	ALyK8tIbqPLOtVzBxoGeYqlK/RVmlnIMgtCGK6paAJ1T99BXNAm7jq2NVQwTenl1hm2lSYOMROjJnT+Ov16x1g==
X-Received	by 10.202.244.4 with SMTP id s4mr13699041oih.123.1467831687455; Wed, 06 Jul 2016 12:01:27 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	40
Organization	linux.* mail to news gateway
X-Original-Cc	weiyj_lk@163.com, Wei Yongjun <yongjun_wei@trendmicro.com.cn>, LKML <linux-kernel@vger.kernel.org>
X-Original-Date	Wed, 6 Jul 2016 15:01:26 -0400
X-Original-Message-ID	<CAOg9mSSre72QcYjN-=2i49JMfttkBN2KiTo7uSKAgmN7YwA=Pg@mail.gmail.com>
X-Original-References	<1467811431-2535-1-git-send-email-weiyj_lk@163.com> <CAOg9mSStropnZ2LiOFgF6t1Tm3YBeR6eEE8d6m=+wORBVh8ugA@mail.gmail.com> <1467827385.8360.30.camel@perches.com> <CAOg9mSSUe+u7kYAkD-Z8qCrf99Q+1-=tLf0=gtNmPBSe+U=nsA@mail.gmail.com> <1467828683.8360.36.camel@perches.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1437913

Show key headers only | View raw

Joe> That's incorrect.

<blush>... you are right. They mostly return -ENOMEM, but they
mostly don't print an error message. I like printing an error message
when I resolve to an error... a whole bunch of that function is sanity
checking input from userspace, with a specific error message for
any particular failure.

Joe> I don't see how that matters here as there's
Joe> already an OOM on v.alloc failure.

I'd find that if needed, but the first place I'd look when investigating
an Orangefs failure would be the Orangefs logs...

-Mike

On Wed, Jul 6, 2016 at 2:11 PM, Joe Perches <joe@perches.com> wrote:
> On Wed, 2016-07-06 at 14:00 -0400, Mike Marshall wrote:
>> Hi Joe...
>
> Hi Mike.
>
>> I looked around at other code to see how they were using vzalloc...
>> even if it is just the caller of the function that uses vzalloc, most
>> fs's that use vzalloc print an error message when vzalloc fails...
>
> That's incorrect.
>
> There are 72 v.alloc calls in fs/
> 2 of those calls have a specific OOM message.
> There's 1 in reiserfs (old and unsupported) and 1 in orangefs
>
>>  I sure do
>> like to follow the flow of our kernel module all in one place
>> with the gossip statements...
>
> I don't see how that matters here as there's
> already an OOM on v.alloc failure.
>
> cheers, Joe

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH -next] orangefs: use vzalloc() instead of vmalloc()/memset(0) weiyj_lk@163.com - 2016-07-06 15:30 +0200
  Re: [PATCH -next] orangefs: use vzalloc() instead of vmalloc()/memset(0) Mike Marshall <hubcap@omnibond.com> - 2016-07-06 19:30 +0200
    Re: [PATCH -next] orangefs: use vzalloc() instead of  vmalloc()/memset(0) Joe Perches <joe@perches.com> - 2016-07-06 19:50 +0200
      Re: [PATCH -next] orangefs: use vzalloc() instead of vmalloc()/memset(0) Mike Marshall <hubcap@omnibond.com> - 2016-07-06 20:10 +0200
        Re: [PATCH -next] orangefs: use vzalloc() instead of  vmalloc()/memset(0) Joe Perches <joe@perches.com> - 2016-07-06 20:20 +0200
          Re: [PATCH -next] orangefs: use vzalloc() instead of vmalloc()/memset(0) Mike Marshall <hubcap@omnibond.com> - 2016-07-06 21:10 +0200

csiph-web