[PATCH REBASE 2/3] media: s5p-mfc fix memory leak in s5p_mfc_remove()

From	Shuah Khan <shuahkh@osg.samsung.com>
Newsgroups	linux.kernel
Subject	[PATCH REBASE 2/3] media: s5p-mfc fix memory leak in s5p_mfc_remove()
Date	2016-06-28 21:30 +0200
Message-ID	<rP6RQ-2GD-11@gated-at.bofh.it> (permalink)
References	<rP6I9-2Di-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

s5p_mfc_remove() fails to release encoder and decoder video devices.

Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
 drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c
index 274b4f1..f537b74 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c
@@ -1318,6 +1318,8 @@ static int s5p_mfc_remove(struct platform_device *pdev)
 
 	video_unregister_device(dev->vfd_enc);
 	video_unregister_device(dev->vfd_dec);
+	video_device_release(dev->vfd_enc);
+	video_device_release(dev->vfd_dec);
 	v4l2_device_unregister(&dev->v4l2_dev);
 	s5p_mfc_release_firmware(dev);
 	vb2_dma_contig_cleanup_ctx(dev->alloc_ctx[0]);
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH REBASE 0/3] Rebased on linuxtv/master  Shuah Khan <shuahkh@osg.samsung.com> - 2016-06-28 21:20 +0200
  [PATCH REBASE 3/3] media: s5p-mfc fix null pointer deference in clk_core_enable() Shuah Khan <shuahkh@osg.samsung.com> - 2016-06-28 21:20 +0200
  [PATCH REBASE 1/3] media: s5p-mfc fix video device release double release in probe error path Shuah Khan <shuahkh@osg.samsung.com> - 2016-06-28 21:20 +0200
  [PATCH REBASE 2/3] media: s5p-mfc fix memory leak in s5p_mfc_remove() Shuah Khan <shuahkh@osg.samsung.com> - 2016-06-28 21:30 +0200

csiph-web