Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1433225
| From | Shuah Khan <shuahkh@osg.samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH REBASE 1/3] media: s5p-mfc fix video device release double release in probe error path |
| Date | 2016-06-28 21:20 +0200 |
| Message-ID | <rP6I9-2Di-9@gated-at.bofh.it> (permalink) |
| References | <rP6I9-2Di-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Fix Decoder and encoder video device double release in probe error path.
video_device_release(dev->vfd_dec) get called twice if decoder register
fails. Also, video_device_release(dev->vfd_enc) get called twice if encoder
register fails.
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c
index 6ee620e..274b4f1 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c
@@ -1266,7 +1266,6 @@ static int s5p_mfc_probe(struct platform_device *pdev)
ret = video_register_device(dev->vfd_dec, VFL_TYPE_GRABBER, 0);
if (ret) {
v4l2_err(&dev->v4l2_dev, "Failed to register video device\n");
- video_device_release(dev->vfd_dec);
goto err_dec_reg;
}
v4l2_info(&dev->v4l2_dev,
@@ -1275,7 +1274,6 @@ static int s5p_mfc_probe(struct platform_device *pdev)
ret = video_register_device(dev->vfd_enc, VFL_TYPE_GRABBER, 0);
if (ret) {
v4l2_err(&dev->v4l2_dev, "Failed to register video device\n");
- video_device_release(dev->vfd_enc);
goto err_enc_reg;
}
v4l2_info(&dev->v4l2_dev,
--
2.7.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH REBASE 0/3] Rebased on linuxtv/master Shuah Khan <shuahkh@osg.samsung.com> - 2016-06-28 21:20 +0200 [PATCH REBASE 3/3] media: s5p-mfc fix null pointer deference in clk_core_enable() Shuah Khan <shuahkh@osg.samsung.com> - 2016-06-28 21:20 +0200 [PATCH REBASE 1/3] media: s5p-mfc fix video device release double release in probe error path Shuah Khan <shuahkh@osg.samsung.com> - 2016-06-28 21:20 +0200 [PATCH REBASE 2/3] media: s5p-mfc fix memory leak in s5p_mfc_remove() Shuah Khan <shuahkh@osg.samsung.com> - 2016-06-28 21:30 +0200
csiph-web