Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1433143

Re: [PATCH 01/23] [AARCH64] define word size for lp64 and ilp32

Show all headers | View raw

On Tue, 28 Jun 2016, Yury Norov wrote:

> diff --git a/sysdeps/aarch64/bits/wordsize.h b/sysdeps/aarch64/bits/wordsize.h

See what I said in 
<https://sourceware.org/ml/libc-alpha/2016-06/msg00786.html> about "make 
other bits/wordsize.h files define the macro to 0".  This patch would 
break all other architectures (and AArch64 LP64 - you should test build 
and testsuite for that, as well as ILP32, and confirm that there are no 
testsuite regressions for LP64).

> +/* Copyright (C) 2014 Free Software Foundation, Inc.

See what I said in 
<https://sourceware.org/ml/libc-alpha/2016-06/msg00780.html> about 
one-line descriptions before copyright notices.  Please check every new 
file in every patch in the series for this issue.

All copyright notices should have ranges of years that end in 2016.

-- 
Joseph S. Myers
joseph@codesourcery.com

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 01/23] [AARCH64] define word size for lp64 and ilp32 Joseph Myers <joseph@codesourcery.com> - 2016-06-28 19:10 +0200
  Re: [PATCH 01/23] [AARCH64] define word size for lp64 and ilp32 Joseph Myers <joseph@codesourcery.com> - 2016-06-28 19:50 +0200

csiph-web