Re: [PATCH] PM / devfreq: Send the DEVFREQ_POSTCHANGE notification when target() is failed

From	"Rafael J. Wysocki" <rafael@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] PM / devfreq: Send the DEVFREQ_POSTCHANGE notification when target() is failed
Date	2016-06-23 15:50 +0200
Message-ID	<rNdb3-2hy-11@gated-at.bofh.it> (permalink)
References	<rN2pj-3uG-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 23, 2016 at 4:18 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> This patch sends the DEVFREQ_POSTCHANGE notification when
> devfreq->profile->targer() is failed. The PRECHANGE/POSTCHANGE
> should be paired.
>
> Fixes: 0fe3a66410a3 ("PM / devfreq: Add new DEVFREQ_TRANSITION_NOTIFIER notifier")
> Reported-by: Lin Huang <hl@rock-chips.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
>  drivers/devfreq/devfreq.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 1d6c803804d5..387799fec4c3 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -268,8 +268,11 @@ int update_devfreq(struct devfreq *devfreq)
>         devfreq_notify_transition(devfreq, &freqs, DEVFREQ_PRECHANGE);
>
>         err = devfreq->profile->target(devfreq->dev.parent, &freq, flags);
> -       if (err)
> +       if (err) {
> +               freqs.new = cur_freq;
> +               devfreq_notify_transition(devfreq, &freqs, DEVFREQ_POSTCHANGE);
>                 return err;
> +       }
>
>         freqs.new = freq;
>         devfreq_notify_transition(devfreq, &freqs, DEVFREQ_POSTCHANGE);
> --

This looks like a fix for a recent regression, so I can apply it directly.

Do you want me to do that?

Thanks,
Rafael

Thread

[PATCH] PM / devfreq: Send the DEVFREQ_POSTCHANGE notification when  target() is failed Chanwoo Choi <cw00.choi@samsung.com> - 2016-06-23 04:20 +0200
  Re: [PATCH] PM / devfreq: Send the DEVFREQ_POSTCHANGE notification  when target() is failed "Rafael J. Wysocki" <rafael@kernel.org> - 2016-06-23 15:50 +0200
    Re: [PATCH] PM / devfreq: Send the DEVFREQ_POSTCHANGE notification  when target() is failed Chanwoo Choi <cwchoi00@gmail.com> - 2016-06-23 16:30 +0200
    RE: Re: [PATCH] PM / devfreq: Send the DEVFREQ_POSTCHANGE notification when target() is failed MyungJoo Ham <myungjoo.ham@samsung.com> - 2016-06-24 02:30 +0200
      Re: [PATCH] PM / devfreq: Send the DEVFREQ_POSTCHANGE notification when target() is failed "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-24 15:40 +0200

csiph-web