Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1429401 > unrolled thread
| Started by | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| First post | 2016-06-23 04:20 +0200 |
| Last post | 2016-06-24 15:40 +0200 |
| Articles | 5 — 5 participants |
Back to article view | Back to linux.kernel
[PATCH] PM / devfreq: Send the DEVFREQ_POSTCHANGE notification when target() is failed Chanwoo Choi <cw00.choi@samsung.com> - 2016-06-23 04:20 +0200
Re: [PATCH] PM / devfreq: Send the DEVFREQ_POSTCHANGE notification when target() is failed "Rafael J. Wysocki" <rafael@kernel.org> - 2016-06-23 15:50 +0200
Re: [PATCH] PM / devfreq: Send the DEVFREQ_POSTCHANGE notification when target() is failed Chanwoo Choi <cwchoi00@gmail.com> - 2016-06-23 16:30 +0200
RE: Re: [PATCH] PM / devfreq: Send the DEVFREQ_POSTCHANGE notification when target() is failed MyungJoo Ham <myungjoo.ham@samsung.com> - 2016-06-24 02:30 +0200
Re: [PATCH] PM / devfreq: Send the DEVFREQ_POSTCHANGE notification when target() is failed "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-24 15:40 +0200
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2016-06-23 04:20 +0200 |
| Subject | [PATCH] PM / devfreq: Send the DEVFREQ_POSTCHANGE notification when target() is failed |
| Message-ID | <rN2pj-3uG-1@gated-at.bofh.it> |
This patch sends the DEVFREQ_POSTCHANGE notification when
devfreq->profile->targer() is failed. The PRECHANGE/POSTCHANGE
should be paired.
Fixes: 0fe3a66410a3 ("PM / devfreq: Add new DEVFREQ_TRANSITION_NOTIFIER notifier")
Reported-by: Lin Huang <hl@rock-chips.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
drivers/devfreq/devfreq.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 1d6c803804d5..387799fec4c3 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -268,8 +268,11 @@ int update_devfreq(struct devfreq *devfreq)
devfreq_notify_transition(devfreq, &freqs, DEVFREQ_PRECHANGE);
err = devfreq->profile->target(devfreq->dev.parent, &freq, flags);
- if (err)
+ if (err) {
+ freqs.new = cur_freq;
+ devfreq_notify_transition(devfreq, &freqs, DEVFREQ_POSTCHANGE);
return err;
+ }
freqs.new = freq;
devfreq_notify_transition(devfreq, &freqs, DEVFREQ_POSTCHANGE);
--
1.9.1
[toc] | [next] | [standalone]
| From | "Rafael J. Wysocki" <rafael@kernel.org> |
|---|---|
| Date | 2016-06-23 15:50 +0200 |
| Subject | Re: [PATCH] PM / devfreq: Send the DEVFREQ_POSTCHANGE notification when target() is failed |
| Message-ID | <rNdb3-2hy-11@gated-at.bofh.it> |
| In reply to | #1429401 |
On Thu, Jun 23, 2016 at 4:18 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> This patch sends the DEVFREQ_POSTCHANGE notification when
> devfreq->profile->targer() is failed. The PRECHANGE/POSTCHANGE
> should be paired.
>
> Fixes: 0fe3a66410a3 ("PM / devfreq: Add new DEVFREQ_TRANSITION_NOTIFIER notifier")
> Reported-by: Lin Huang <hl@rock-chips.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> drivers/devfreq/devfreq.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 1d6c803804d5..387799fec4c3 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -268,8 +268,11 @@ int update_devfreq(struct devfreq *devfreq)
> devfreq_notify_transition(devfreq, &freqs, DEVFREQ_PRECHANGE);
>
> err = devfreq->profile->target(devfreq->dev.parent, &freq, flags);
> - if (err)
> + if (err) {
> + freqs.new = cur_freq;
> + devfreq_notify_transition(devfreq, &freqs, DEVFREQ_POSTCHANGE);
> return err;
> + }
>
> freqs.new = freq;
> devfreq_notify_transition(devfreq, &freqs, DEVFREQ_POSTCHANGE);
> --
This looks like a fix for a recent regression, so I can apply it directly.
Do you want me to do that?
Thanks,
Rafael
[toc] | [prev] | [next] | [standalone]
| From | Chanwoo Choi <cwchoi00@gmail.com> |
|---|---|
| Date | 2016-06-23 16:30 +0200 |
| Subject | Re: [PATCH] PM / devfreq: Send the DEVFREQ_POSTCHANGE notification when target() is failed |
| Message-ID | <rNdNM-2OV-19@gated-at.bofh.it> |
| In reply to | #1429839 |
Hi,
2016-06-23 22:40 GMT+09:00 Rafael J. Wysocki <rafael@kernel.org>:
> On Thu, Jun 23, 2016 at 4:18 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>> This patch sends the DEVFREQ_POSTCHANGE notification when
>> devfreq->profile->targer() is failed. The PRECHANGE/POSTCHANGE
>> should be paired.
>>
>> Fixes: 0fe3a66410a3 ("PM / devfreq: Add new DEVFREQ_TRANSITION_NOTIFIER notifier")
>> Reported-by: Lin Huang <hl@rock-chips.com>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> ---
>> drivers/devfreq/devfreq.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
>> index 1d6c803804d5..387799fec4c3 100644
>> --- a/drivers/devfreq/devfreq.c
>> +++ b/drivers/devfreq/devfreq.c
>> @@ -268,8 +268,11 @@ int update_devfreq(struct devfreq *devfreq)
>> devfreq_notify_transition(devfreq, &freqs, DEVFREQ_PRECHANGE);
>>
>> err = devfreq->profile->target(devfreq->dev.parent, &freq, flags);
>> - if (err)
>> + if (err) {
>> + freqs.new = cur_freq;
>> + devfreq_notify_transition(devfreq, &freqs, DEVFREQ_POSTCHANGE);
>> return err;
>> + }
>>
>> freqs.new = freq;
>> devfreq_notify_transition(devfreq, &freqs, DEVFREQ_POSTCHANGE);
>> --
>
> This looks like a fix for a recent regression, so I can apply it directly.
>
> Do you want me to do that?
Yes. Thanks for picking this patch up.
Regards,
Chanwoo Choi
[toc] | [prev] | [next] | [standalone]
| From | MyungJoo Ham <myungjoo.ham@samsung.com> |
|---|---|
| Date | 2016-06-24 02:30 +0200 |
| Subject | RE: Re: [PATCH] PM / devfreq: Send the DEVFREQ_POSTCHANGE notification when target() is failed |
| Message-ID | <rNnaq-QK-13@gated-at.bofh.it> |
| In reply to | #1429839 |
[Multipart message — attachments visible in raw view] — view raw
> Hi,
>
> 2016-06-23 22:40 GMT+09:00 Rafael J. Wysocki <rafael@kernel.org>:
> > On Thu, Jun 23, 2016 at 4:18 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> >> This patch sends the DEVFREQ_POSTCHANGE notification when
> >> devfreq->profile->targer() is failed. The PRECHANGE/POSTCHANGE
> >> should be paired.
> >>
> >> Fixes: 0fe3a66410a3 ("PM / devfreq: Add new DEVFREQ_TRANSITION_NOTIFIER notifier")
> >> Reported-by: Lin Huang <hl@rock-chips.com>
> >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> >> ---
> >
> > This looks like a fix for a recent regression, so I can apply it directly.
> >
> > Do you want me to do that?
>
> Yes. Thanks for picking this patch up.
>
> Regards,
> Chanwoo Choi
>
>
That'd be great. Thanks!
Cheers,
MyungJoo
[toc] | [prev] | [next] | [standalone]
| From | "Rafael J. Wysocki" <rjw@rjwysocki.net> |
|---|---|
| Date | 2016-06-24 15:40 +0200 |
| Subject | Re: [PATCH] PM / devfreq: Send the DEVFREQ_POSTCHANGE notification when target() is failed |
| Message-ID | <rNzuW-cP-31@gated-at.bofh.it> |
| In reply to | #1430261 |
On Friday, June 24, 2016 12:28:09 AM MyungJoo Ham wrote:
> > Hi,
> >
> > 2016-06-23 22:40 GMT+09:00 Rafael J. Wysocki <rafael@kernel.org>:
> > > On Thu, Jun 23, 2016 at 4:18 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> > >> This patch sends the DEVFREQ_POSTCHANGE notification when
> > >> devfreq->profile->targer() is failed. The PRECHANGE/POSTCHANGE
> > >> should be paired.
> > >>
> > >> Fixes: 0fe3a66410a3 ("PM / devfreq: Add new DEVFREQ_TRANSITION_NOTIFIER notifier")
> > >> Reported-by: Lin Huang <hl@rock-chips.com>
> > >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> > >> ---
> > >
> > > This looks like a fix for a recent regression, so I can apply it directly.
> > >
> > > Do you want me to do that?
> >
> > Yes. Thanks for picking this patch up.
> >
> > Regards,
> > Chanwoo Choi
> >
> >
>
> That'd be great. Thanks!
OK, applied.
Thanks!
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web