Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1427405

[PATCH v2 02/17] RTC: ds1307: Disable square wave and timers as default

Show all headers | View raw

Disable square wave and timers as default for DS1337/39/41 and
DS3231. The rationale being that configuring a chip this way puts it
into a known state with lower power consumption. While it is not very
likely it is still possible that the code controlling RTCs that ran
before this driver configured it to produce square wave and left it in
such a state.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 drivers/rtc/rtc-ds1307.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
index 7e65e2e..c618c22 100644
--- a/drivers/rtc/rtc-ds1307.c
+++ b/drivers/rtc/rtc-ds1307.c
@@ -1320,19 +1320,17 @@ static int ds1307_probe(struct i2c_client *client,
 			ds1307->regs[0] &= ~DS1337_BIT_nEOSC;
 
 		/*
-		 * Using IRQ or defined as wakeup-source?
 		 * Disable the square wave and both alarms.
 		 * For some variants, be sure alarms can trigger when we're
 		 * running on Vbackup (BBSQI/BBSQW)
 		 */
-		if (chip->alarm && (ds1307->client->irq > 0 ||
-						ds1307_can_wakeup_device)) {
-			ds1307->regs[0] |= DS1337_BIT_INTCN
-					| bbsqi_bitpos[ds1307->type];
-			ds1307->regs[0] &= ~(DS1337_BIT_A2IE | DS1337_BIT_A1IE);
+		ds1307->regs[0] |= DS1337_BIT_INTCN
+			| bbsqi_bitpos[ds1307->type];
+		ds1307->regs[0] &= ~(DS1337_BIT_A2IE | DS1337_BIT_A1IE);
 
+		if (chip->alarm && (ds1307->client->irq > 0 ||
+				    ds1307_can_wakeup_device))
 			want_irq = true;
-		}
 
 		i2c_smbus_write_byte_data(client, DS1337_REG_CONTROL,
 							ds1307->regs[0]);
-- 
2.5.5

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 02/17] RTC: ds1307: Disable square wave and timers as default Andrey Smirnov <andrew.smirnov@gmail.com> - 2016-06-21 09:30 +0200
  [PATCH v2 13/17] RTC: ds1307: Report oscillator problems more intelligently Andrey Smirnov <andrew.smirnov@gmail.com> - 2016-06-21 09:30 +0200
    Re: [PATCH v2 13/17] RTC: ds1307: Report oscillator problems more  intelligently Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-06-21 23:30 +0200
      Re: [PATCH v2 13/17] RTC: ds1307: Report oscillator problems more intelligently Andrey Smirnov <andrew.smirnov@gmail.com> - 2016-06-22 01:10 +0200
  [PATCH v2 10/17] RTC: ds1307: Constify struct ds1307 where possible Andrey Smirnov <andrew.smirnov@gmail.com> - 2016-06-21 09:30 +0200
  Re: [PATCH v2 02/17] RTC: ds1307: Disable square wave and timers as  default Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-06-21 23:20 +0200
    Re: [PATCH v2 02/17] RTC: ds1307: Disable square wave and timers as default Andrey Smirnov <andrew.smirnov@gmail.com> - 2016-06-22 01:50 +0200

csiph-web