Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1428254

Re: [PATCH v2 13/17] RTC: ds1307: Report oscillator problems more intelligently

Show all headers | View raw

On Tue, Jun 21, 2016 at 2:22 PM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> On 21/06/2016 at 00:22:46 -0700, Andrey Smirnov wrote :
>> Report oscillator problems more intelligently, by printing more
>> information about what cause the issue and not yelling "SET TIME!" at
>> the user.
>>
>
> Well, the proper way of doing that is to ensure that -EINVAL is returned
> when reading the time until it has been set once instead of starting the
> oscillator and forgetting about that useful information.

Agreed, will change in v3.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 02/17] RTC: ds1307: Disable square wave and timers as default Andrey Smirnov <andrew.smirnov@gmail.com> - 2016-06-21 09:30 +0200
  [PATCH v2 13/17] RTC: ds1307: Report oscillator problems more intelligently Andrey Smirnov <andrew.smirnov@gmail.com> - 2016-06-21 09:30 +0200
    Re: [PATCH v2 13/17] RTC: ds1307: Report oscillator problems more  intelligently Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-06-21 23:30 +0200
      Re: [PATCH v2 13/17] RTC: ds1307: Report oscillator problems more intelligently Andrey Smirnov <andrew.smirnov@gmail.com> - 2016-06-22 01:10 +0200
  [PATCH v2 10/17] RTC: ds1307: Constify struct ds1307 where possible Andrey Smirnov <andrew.smirnov@gmail.com> - 2016-06-21 09:30 +0200
  Re: [PATCH v2 02/17] RTC: ds1307: Disable square wave and timers as  default Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-06-21 23:20 +0200
    Re: [PATCH v2 02/17] RTC: ds1307: Disable square wave and timers as default Andrey Smirnov <andrew.smirnov@gmail.com> - 2016-06-22 01:50 +0200

csiph-web