Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1428140
| From | David Rientjes <rientjes@google.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/3] staging: lowmemorykiller: change lowmem_adj to lowmem_score_adj |
| Date | 2016-06-21 22:40 +0200 |
| Message-ID | <rMACK-2cL-23@gated-at.bofh.it> (permalink) |
| References | <rMmzL-1zb-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, 21 Jun 2016, Ganesh Mahendran wrote:
> om_adj is deprecated, and in lowmemorykiller module, we use score adj
> to do the comparing.
> ---
> oom_score_adj = p->signal->oom_score_adj;
> if (oom_score_adj < min_score_adj) {
> task_unlock(p);
> continue;
> }
> ---
>
> This patch makes the variable name consistent with the usage.
>
Umm, I don't think you can just remove a parameter to a module and replace
it with something that has a different unit and not think that userspace
will break as a result.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/3] staging: lowmemorykiller: change lowmem_adj to lowmem_score_adj Ganesh Mahendran <opensource.ganesh@gmail.com> - 2016-06-21 07:40 +0200
[PATCH 3/3] staging: lowmemorykiller: select the task with maximum rss to kill Ganesh Mahendran <opensource.ganesh@gmail.com> - 2016-06-21 07:40 +0200
Re: [PATCH 3/3] staging: lowmemorykiller: select the task with maximum rss to kill David Rientjes <rientjes@google.com> - 2016-06-21 23:20 +0200
Re: [PATCH 3/3] staging: lowmemorykiller: select the task with maximum rss to kill Ganesh Mahendran <opensource.ganesh@gmail.com> - 2016-06-22 06:50 +0200
Re: [PATCH 1/3] staging: lowmemorykiller: change lowmem_adj to lowmem_score_adj David Rientjes <rientjes@google.com> - 2016-06-21 22:40 +0200
Re: [PATCH 1/3] staging: lowmemorykiller: change lowmem_adj to lowmem_score_adj Ganesh Mahendran <opensource.ganesh@gmail.com> - 2016-06-22 06:10 +0200
csiph-web