Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1428173

Re: [PATCH 3/3] staging: lowmemorykiller: select the task with maximum rss to kill

Show all headers | View raw

On Tue, 21 Jun 2016, Ganesh Mahendran wrote:

> Current task selecting logic in LMK does not fully aware of the memory
> pressure. It may select the task with maximum score adj, but with
> least tasksize.
> 
> For example, if min_score_adj is 200, and there are 2 tasks in system:
>    task a: score adj 500, tasksize 200M
>    task b: score adj 1000, tasksize 1M
> Current LMK logic will select *task b*. But now the system already have
> much memory pressure.
> 
> We should select the task with maximum task from all the tasks which
> score adj >= min_score_adj.
> 

Unfortunately, I'm not sure that we can get away with this although I 
agree that it is a better result (kill a large process, avoid lowmem or 
oom for longer).

It changes the kill order for systems that have already fine-tuned their 
oom_score_adj settings and can regress because of this change.  If systems 
really want task b to be killed above, this breaks and they have no 
immediate way of fixing it.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] staging: lowmemorykiller: change lowmem_adj to lowmem_score_adj Ganesh Mahendran <opensource.ganesh@gmail.com> - 2016-06-21 07:40 +0200
  [PATCH 3/3] staging: lowmemorykiller: select the task with maximum rss to kill Ganesh Mahendran <opensource.ganesh@gmail.com> - 2016-06-21 07:40 +0200
    Re: [PATCH 3/3] staging: lowmemorykiller: select the task with  maximum rss to kill David Rientjes <rientjes@google.com> - 2016-06-21 23:20 +0200
      Re: [PATCH 3/3] staging: lowmemorykiller: select the task with  maximum rss to kill Ganesh Mahendran <opensource.ganesh@gmail.com> - 2016-06-22 06:50 +0200
  Re: [PATCH 1/3] staging: lowmemorykiller: change lowmem_adj to  lowmem_score_adj David Rientjes <rientjes@google.com> - 2016-06-21 22:40 +0200
    Re: [PATCH 1/3] staging: lowmemorykiller: change lowmem_adj to  lowmem_score_adj Ganesh Mahendran <opensource.ganesh@gmail.com> - 2016-06-22 06:10 +0200

csiph-web