Re: [PATCH 1/1] v4l: Add camera voice coil lens control class, current control

From	Pavel Machek <pavel@ucw.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] v4l: Add camera voice coil lens control class, current control
Date	2016-06-18 00:10 +0200
Message-ID	<rLa7D-3SN-15@gated-at.bofh.it> (permalink)
References	<rDx1o-8ea-11@gated-at.bofh.it> <rJkut-4Uj-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi!

> -</section>
> +
> +    <section id="voice-coil-controls">
> +      <title>Voice Coil Control Reference</title>
> +
> +      <para>The Voice Coil class controls are used to control voice
> +      coil lens devices. These are very simple devices that consist of
> +      a voice coil, a spring and a lens. The current applied on a

"on the"?

> +      voice coil is used to move the lens away from the resting
> +      position which typically is (close to) infinity.</para>

Insert explanation that this all is for autofocus somewhere?

>  /* User-class control IDs */
>  
> @@ -974,4 +975,10 @@ enum v4l2_detect_md_mode {
>  #define V4L2_CID_DETECT_MD_THRESHOLD_GRID	(V4L2_CID_DETECT_CLASS_BASE + 3)
>  #define V4L2_CID_DETECT_MD_REGION_GRID		(V4L2_CID_DETECT_CLASS_BASE + 4)
>  
> +/*  Voice coil lens driver control IDs defined by V4L2 */

Too many spaces after '/*'. 

Otherwise, you have my "acked-by".

Thanks,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] v4l: Add camera voice coil lens control class, current control Sakari Ailus <sakari.ailus@linux.intel.com> - 2016-06-12 22:50 +0200
  Re: [PATCH 1/1] v4l: Add camera voice coil lens control class,  current control Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-06-12 23:50 +0200
    Re: [PATCH 1/1] v4l: Add camera voice coil lens control class,  current control Pavel Machek <pavel@ucw.cz> - 2016-06-18 00:20 +0200
      Re: [PATCH 1/1] v4l: Add camera voice coil lens control class, current control Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-06-18 00:40 +0200
        Re: [PATCH 1/1] v4l: Add camera voice coil lens control class,  current control Pavel Machek <pavel@ucw.cz> - 2016-06-18 13:30 +0200
  Re: [PATCH 1/1] v4l: Add camera voice coil lens control class,  current control Pavel Machek <pavel@ucw.cz> - 2016-06-18 00:10 +0200

csiph-web