Re: [PATCH 1/1] v4l: Add camera voice coil lens control class, current control

From	Pavel Machek <pavel@ucw.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] v4l: Add camera voice coil lens control class, current control
Date	2016-06-18 00:20 +0200
Message-ID	<rLahk-3W9-19@gated-at.bofh.it> (permalink)
References	<rDx1o-8ea-11@gated-at.bofh.it> <rJkut-4Uj-1@gated-at.bofh.it> <rJlqz-5ve-59@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi!

> >I also don't think the FOCUS_ABSOLUTE controls is a really good one for
> >the voice coil lens current. I expect more voice coil lens controls
> >(linear vs. PWM mode, ringing compensation...) to be needed so I think
> >it's worth a new class.

Well, I do agree that that the new class is fine (and have no problem
with your proposal), but I'd like to understand why FOCUS_ABSOLUTE is
unsuitable. I'm actually thinking about writing very simple userspace
camera, without autofocus, where user would just select
"infinity"/"1m"/"50cm" ... and for that FOCUS_ABSOLUTE is equivalent
to VOICE_COIL_CURRENT...

> Right, I still think movement mode should be standard control :)

What options would you like to see for movement mode?

Thanks,
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Thread

[PATCH 1/1] v4l: Add camera voice coil lens control class, current control Sakari Ailus <sakari.ailus@linux.intel.com> - 2016-06-12 22:50 +0200
  Re: [PATCH 1/1] v4l: Add camera voice coil lens control class,  current control Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-06-12 23:50 +0200
    Re: [PATCH 1/1] v4l: Add camera voice coil lens control class,  current control Pavel Machek <pavel@ucw.cz> - 2016-06-18 00:20 +0200
      Re: [PATCH 1/1] v4l: Add camera voice coil lens control class, current control Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-06-18 00:40 +0200
        Re: [PATCH 1/1] v4l: Add camera voice coil lens control class,  current control Pavel Machek <pavel@ucw.cz> - 2016-06-18 13:30 +0200
  Re: [PATCH 1/1] v4l: Add camera voice coil lens control class,  current control Pavel Machek <pavel@ucw.cz> - 2016-06-18 00:10 +0200

csiph-web