Re: lm-senser can't detect thermal on thermal_zone

From	Zhang Rui <rui.zhang@intel.com>
Newsgroups	linux.kernel
Subject	Re: lm-senser can't detect thermal on thermal_zone
Date	2016-06-14 08:40 +0200
Message-ID	<rJQaZ-134-3@gated-at.bofh.it> (permalink)
References	<ry9sK-t7-9@gated-at.bofh.it> <ry9sK-t7-7@gated-at.bofh.it> <rJQaZ-134-5@gated-at.bofh.it> <rJQaZ-134-7@gated-at.bofh.it> <rJQaZ-134-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2016-06-09 at 03:07 +0000, Kuninori Morimoto wrote:
> 
> Hi Zhang
> 
> Can you check this email ?
> 
> > 
> > > 
> > > Thank you for your help
> > > 
> > > > 
> > > > > 
> > > > > 	non thermal-zon
> > > > > 	  sensor command: OK
> > > > > 	  read from /sys/class/thermal/thermal_zone0 : OK
> > > > > 
> > > > > 	thermal-zon
> > > > > 	  sensor command: NG
> > > > > 	  read from /sys/class/thermal/thermal_zone0 : OK
> > > > config THERMAL_HWMON
> > > >         bool
> > > >         prompt "Expose thermal sensors as hwmon device"
> > > >         depends on HWMON=y || HWMON=THERMAL
> > > >         default y
> > > > 
> > > > please check if the thermal subsystem is built in, while hwmon
> > > > subsystem
> > > > is built as module.
> > > > you should either set CONFIG_HWMON=y, or set both CONFIG_HWMON
> > > > and
> > > > CONFIG_THERMAL as module.
> > > Thanks. but it seems our system has it.
> > > 
> > > I noticed that thermal_zone case uses of_parse_thermal_zones()
> > > and it has this.
> > > 
> > > 		/* No hwmon because there might be hwmon drivers
> > > registering */
> > > 		tzp->no_hwmon = true;
> > > 
> > > and on thermal_zone_device_register() check this for hwmon
> > > 
> > > struct thermal_zone_device *thermal_zone_device_register(xxxx)
> > > {
> > > 	...
> > > 	if (!tz->tzp || !tz->tzp->no_hwmon) {
> > > 		result = thermal_add_hwmon_sysfs(tz);
> > > 		...
> > > 	}
> > > 	...
> > > }
> > > 
> > > Does this mean "thermal_zone doesn't use lm-senser" ?

I'd prefer to say of_thermal registered thermal_zone doesn't use lm-
sensor.
If you're really want to see hwmon interface, I think you should use
thermal API (thermal_zone_device_register) directly.

thanks,
rui

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: lm-senser can't detect thermal on thermal_zone Zhang Rui <rui.zhang@intel.com> - 2016-06-14 08:40 +0200
  Re: lm-senser can't detect thermal on thermal_zone Zhang Rui <rui.zhang@intel.com> - 2016-06-14 15:30 +0200

csiph-web