Groups > linux.kernel > #1421900

Re: lm-senser can't detect thermal on thermal_zone

From	Zhang Rui <rui.zhang@intel.com>
Newsgroups	linux.kernel
Subject	Re: lm-senser can't detect thermal on thermal_zone
Date	2016-06-14 15:30 +0200
Message-ID	<rJWzL-5ng-1@gated-at.bofh.it> (permalink)
References	(2 earlier) <rJQaZ-134-5@gated-at.bofh.it> <rJQaZ-134-7@gated-at.bofh.it> <rJQaZ-134-9@gated-at.bofh.it> <rJQaZ-134-3@gated-at.bofh.it> <rJWzL-5ng-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 二, 2016-06-14 at 07:03 +0000, Kuninori Morimoto wrote:
> Hi Zhang
> 
> > 
> > > 
> > > > 
> > > > > 
> > > > > struct thermal_zone_device
> > > > > *thermal_zone_device_register(xxxx)
> > > > > {
> > > > > 	...
> > > > > 	if (!tz->tzp || !tz->tzp->no_hwmon) {
> > > > > 		result = thermal_add_hwmon_sysfs(tz);
> > > > > 		...
> > > > > 	}
> > > > > 	...
> > > > > }
> > > > > 
> > > > > Does this mean "thermal_zone doesn't use lm-senser" ?
> > I'd prefer to say of_thermal registered thermal_zone doesn't use
> > lm-
> > sensor.
> > If you're really want to see hwmon interface, I think you should
> > use
> > thermal API (thermal_zone_device_register) directly.
> Thank you for your feedback.
> My driver is supporting both of_thermal and thermal API.
> So, switching is not a big deal.
> 
> But can you teach me why of_thermal doesn't use lm-senser ??

I don't know if there is a solid reason that we can not expose the
hwmon interface. But just like the comment says, "/* No hwmon because
there might be hwmon drivers registering */", given that of_thermal
just parses THERMAL data of device tree, it is reasonable to me for
exposing thermal interfaces only.

thanks,
rui

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: lm-senser can't detect thermal on thermal_zone Zhang Rui <rui.zhang@intel.com> - 2016-06-14 08:40 +0200
  Re: lm-senser can't detect thermal on thermal_zone Zhang Rui <rui.zhang@intel.com> - 2016-06-14 15:30 +0200

csiph-web